229199 - CTRL+L behavior broken in FB (not Moz 1.5)

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[damn23]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031218 Firebird/0.7+

When the Navigation toolbar is hidden and you press Ctrl+L, the old style
location window pops up(the one that looks like Ctrl+****+L in Mozilla). typing
an address and hitting <enter> opens a new window (in modal mode, so you cant go
back to the prev window without closing this one) but does not load the page.
The previous window still has the "open location" dialog.

Reproducible: Always

Steps to Reproduce:
1. Hide Navigation toolbar(right click, uncheck nav toolbar)
2. Press Ctrl+L to bring up "open location" dialog box.
3. Enter a url and press <enter>

Actual Results:  
FB opens a new window in Modal mode. It does not load the requested URl. The
original window is still there in the background with the open location dialog
still open.

This happens weather you chose to open in a new window/this window or new tab
from the drop down in the open location dialog box.

Expected Results:  
opened the new url in the appropriate window/tab and hidden the open location
dialog.

This problem does not exist in mozilla 1.5
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5) Gecko/20031007.

I have not checked newer Mozilla builds.

Comment 1

[José Jeria]

Same on XP, build 20031218.

Comment 2

[Simon Paquet [:sipaq]]

Confirming bug on W2K with 2004-01-09 trunk build

Comment 3

[José Jeria]

*** Bug 234874 has been marked as a duplicate of this bug. ***

Comment 4

[PikeUK]

This is caused by an orphaned "else {" in onChooseFile() in openLocation.js (the
xpfe version has an if statement checking for composer, presumably when that was
removed somebody overlooked removing the equivalent else statement).

http://lxr.mozilla.org/mozilla/source/browser/base/content/openLocation.js#120

Comment 5

[PikeUK]

Attachment: Patch to remove leftover else statement

Trivial patch to fix this problem as described in Comment 4 (note removing the
URL bar causes an error during loading in the latest nightlies due to the
checkin from Bug 176675).

Comment 6

[Blake Ross]

Fixed; good catch!

Comment 7

[Simon Paquet [:sipaq]]

*** Bug 235126 has been marked as a duplicate of this bug. ***