229203 - Need ability to convert new lines into commas for paste into single line text box

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Scott MacGregor]

Thunderbird needs a way to make new lines get converted to commas when getting
pasted into a single line text box. 

We need this to have 4.x partity for the following scenario:
1) Select a group of cells from a spreadsheet like Excel that contain names.
2) Paste that group into the addressing widget. 

4.x would convert those new lines to commas and then we would autocomplete each
one of the comma delimited names.

Currently, we loose all the data except for the first name when we paste because
our current behvior for single line text inputs is to forget everything after
the first new line.

Comment 1

[Scott MacGregor]

Attachment: the fix

I'm spinning this patch out of the overall patch for Bug #227206 since it
requires editor module owner approval.

The pref is only set to replace with commas for thunderbird, we leave everyone
else alone.

One drawback with this solution is that we can't make it work for mozilla
mailnews , since that would require change the pref for all input boxes in
seamonkey.

Comment 2

[Scott MacGregor]

Comment on attachment 137854 [details] [diff] [review]
the fix

asking Kin for a module owner review. He may have a different way he'd like to
solve this that would work for seamonkey and not just thunderbird.

Comment 3

[Scott MacGregor]

Comment on attachment 137854 [details] [diff] [review]
the fix

Daniel, are you ok with adding this functionality to editor to convert new
lines into commas if the pref is set to a value of 4? Prefs already exist to
convert them to spaces, newlines, just the first line, etc. 

This would fix the problem for thunderbird because I can just set the pref to
force newlines to be commas. It won't work for seamonkey though because
seamonkey has other single line text box widgets which won't want this behavior
and the pref is global not per text box.

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 137854 [details] [diff] [review]
the fix

no problem

r=[e-mail]
moa=[e-mail] for editor

Scott, please place definition for enum value eReplaceWithCommas on a new line
so we keep lines of two values; thanks.

Comment 5

[Scott MacGregor]

fixed

Comment 6

[Jesse Ruderman]

Why is this a pref rather than an attribute for XUL textboxes?

Comment 7

[Scott MacGregor]

it'd be great to have it as an attribute on text boxes eventually if someone
wanted to do that.