Closed
Bug 229212
Opened 21 years ago
Closed 21 years ago
SECKEY_ECParamsToKeySize should be declared in a header file.
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.9.1
People
(Reporter: wtc, Assigned: nelson)
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
rrelyea
:
review+
|
Details | Diff | Splinter Review |
The new function SECKEY_ECParamsToKeySize (added during
NSS 3.9 development) is not declared in any header file.
In pk11skey.c, it is manually declared.
We should declare this function in an NSS "private export"
header file (it is defined in lib/cryptohi and used in
both lib/cryptohi and lib/pk11wrap).
|
Assignee | |
Comment 1•21 years ago
|
||
Fix for 3.9.1
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → 3.9.1
|
|
Assignee | |
Comment 2•21 years ago
|
||
|
|
Assignee | |
Comment 3•21 years ago
|
||
Adding reviewer to cc list
|
|
Assignee | |
Comment 4•21 years ago
|
||
Comment on attachment 139521 [details] [diff] [review]
patch v1, move declaration to keyhi.h
Bob, please review.
Do you agree that this is the right place for this declaration?
Attachment #139521 -
Flags: review?(rrelyea0264)
|
||
Updated•21 years ago
|
Attachment #139521 -
Flags: review?(rrelyea0264) → review+
|
|
Assignee | |
Comment 5•21 years ago
|
||
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11skey.c,v <-- pk11skey.c
new revision: 1.84; previous revision: 1.83
/cvsroot/mozilla/security/nss/lib/cryptohi/keyhi.h,v <-- keyhi.h
new revision: 1.9; previous revision: 1.8
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•