229214 - non-subscribable folders in subscribe ui should be grayed out and have the subscribe checkbox hidden)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[David :Bienvenu]

Some imap folders are not subscribable because they're no select. Clicking the
check box won't subscribe you to them, or check the checkbox, but there's no
other feedback. We should have some UI feedback up front for non-subscribable
folders.

Comment 1

[Scott MacGregor]

Attachment: rough draft (the .css is wrong and I still need to fix classic and test, etc)

Comment 2

[Scott MacGregor]

Attachment: patch

Comment 3

[Scott MacGregor]

Attachment: screen shot

Comment 4

[David :Bienvenu]

Comment on attachment 137930 [details] [diff] [review]
patch

r/sr=bienvenu, with one nit Seth is going to fix.

Comment 5

[Scott MacGregor]

fixed.  I fixed the nit david pointed out.

some comments:

1)  this only affects the "tree" view in the subscribe dialog, not the "search" view
2)  the "search" view is news only
3)  news always adds everything as subscribable.


Checking in themes/classic/messenger/subscribe.css;
/cvsroot/mozilla/themes/classic/messenger/subscribe.css,v  <--  subscribe.css
new revision: 1.9; previous revision: 1.8
Checking in themes/modern/messenger/subscribe.css;
/cvsroot/mozilla/themes/modern/messenger/subscribe.css,v  <--  subscribe.css
new revision: 1.18; previous revision: 1.17
done
Checking in mailnews/base/public/nsISubscribableServer.idl;
/cvsroot/mozilla/mailnews/base/public/nsISubscribableServer.idl,v  <--  nsISubsc
ribableServer.idl
new revision: 1.17; previous revision: 1.16
done
Checking in mailnews/base/resources/content/subscribe.xul;
/cvsroot/mozilla/mailnews/base/resources/content/subscribe.xul,v  <--  subscribe
.xul
new revision: 1.97; previous revision: 1.96
done
Checking in mailnews/base/src/nsSubscribableServer.cpp;
/cvsroot/mozilla/mailnews/base/src/nsSubscribableServer.cpp,v  <--  nsSubscribab
leServer.cpp
new revision: 1.40; previous revision: 1.39
done
Checking in mailnews/base/src/nsSubscribeDataSource.cpp;
/cvsroot/mozilla/mailnews/base/src/nsSubscribeDataSource.cpp,v  <--  nsSubscribe
DataSource.cpp
new revision: 1.19; previous revision: 1.18
done
Checking in mailnews/base/src/nsSubscribeDataSource.h;
/cvsroot/mozilla/mailnews/base/src/nsSubscribeDataSource.h,v  <--  nsSubscribeDa
taSource.h
new revision: 1.5; previous revision: 1.4
done
Checking in mailnews/imap/src/nsImapIncomingServer.cpp;
/cvsroot/mozilla/mailnews/imap/src/nsImapIncomingServer.cpp,v  <--  nsImapIncomi
ngServer.cpp
new revision: 1.322; previous revision: 1.321
done
Checking in mailnews/news/src/nsNntpIncomingServer.cpp;
/cvsroot/mozilla/mailnews/news/src/nsNntpIncomingServer.cpp,v  <--  nsNntpIncomi
ngServer.cpp
new revision: 1.145; previous revision: 1.144
done

Comment 6

[Scott MacGregor]

I've also ported this to the tbird trunk.