229293 - lib/base/arena.c: unary minus operator applied to unsigned type

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

When compiling lib/base/arena.c, MSVC issues the following
compiler warnings:

cl -FoWIN954.0_DBG.OBJ/arena.obj -c -Od -Z7 -MD -W3 -nologo -DXP_PC -DDEBUG
-D_DEBUG -UNDEBUG -DDEBUG_bishakhabanerjee -DWIN32 -D_WINDOWS -D_X86_ -DWIN95
-I../../../../dist/WIN954.0_DBG.OBJ/include  -I../../../../dist/public/nss
-I../../../../dist/private/nss -I../../../../dist/public/nspr 
C:/nsstip_tbox/builds/tinderbox/win2K/mozilla/security/nss/lib/base/arena.c
arena.c
C:/nsstip_tbox/builds/tinderbox/win2K/mozilla/security/nss/lib/base/arena.c(964)
: warning C4146: unary minus operator applied to unsigned type, result still
unsigned
C:/nsstip_tbox/builds/tinderbox/win2K/mozilla/security/nss/lib/base/arena.c(1041)
: warning C4146: unary minus operator applied to unsigned type, result still
unsigned

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

&a[-i] is equivalent to a-i.  The latter avoids
the unary minus operator.

Comment 2

[Robert Relyea]

Comment on attachment 137896 [details] [diff] [review]
Proposed patch

a-i is easier to read than &[-i] as well.

Comment 3

[Wan-Teh Chang]

Fixed checked in on the trunk.

Checking in arena.c;
/cvsroot/mozilla/security/nss/lib/base/arena.c,v  <--  arena.c
new revision: 1.6; previous revision: 1.5
done

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.
Setting this to P3, since it was motivated only as warning reduction.