229297 - lib/crmf/crmfdec.c: conversion from 'double ' to 'long ', possible loss of data

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Wan-Teh Chang]

When compiling lib/crmf/crmfdec.c, MSVC issues the
following warning:

cl -FoWIN954.0_DBG.OBJ/crmfdec.obj -c -Od -Z7 -MD -W3 -nologo -DXP_PC -DDEBUG -D
_DEBUG -UNDEBUG -DDEBUG_wtc -DWIN32 -D_WINDOWS -D_X86_ -DWIN95 -I../../../../dis
t/WIN954.0_DBG.OBJ/include  -I../../../../dist/public/nss -I../../../../dist/pri
vate/nss  G:/nss-tip/mozilla/security/nss/lib/crmf/crmfdec.c
crmfdec.c
G:/nss-tip/mozilla/security/nss/lib/crmf/crmfdec.c(349) : warning C4244: '=' : c
onversion from 'double ' to 'long ', possible loss of data

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

Use the equivalent integer arithmetic.

Comment 2

[Julien Pierre]

Comment on attachment 137899 [details] [diff] [review]
Proposed patch

This patch fixes the compiler warning and is equivalent to the old code. I'm
not sure if the guesstimate is the correct thing to do, but I don't know too
much about CRMF requests size.

Comment 3

[Robert Relyea]

Comment on attachment 137899 [details] [diff] [review]
Proposed patch

A quick look indicates that we should also increase arenaSize by sizeof(
CRMFCertReqMessages).

This isn't an issue since arenaSize is the arena page size, If the value is to
small, the code still functions, only more slowly.

Comment 4

[Wan-Teh Chang]

Patch checked into the trunk.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Setting priorities on unprioritized bugs resolved fixed for NSS 3.10.
Setting this to P3, since it was motivated only as warning reduction.