229392 - Random cleanup in session history code

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Harshal Pradhan]

I was looking through some session history code and found a bit of code that is
seems useless and can trivially be eliminated. I'll shortly attach a patch that
eliminates it.

Comment 1

[Harshal Pradhan]

Attachment: Get rid of some code

This patch does 2 things 
- Move all of nsSHistory::PrintHistory() which is clearly debug code into
  #ifdef DEBUG
- Elimiate code related to lrvList attribute in nsISHTransaction.
  This seems to have been an attempt to implement some kind of branching in
  session history instead of the current linear implemenation. In any
  case, its never worked and has always been disabled going back to even very
  early versions in cvs.

Comment 2

[Harshal Pradhan]

Comment on attachment 137958 [details] [diff] [review]
Get rid of some code

Radha does not seem to be around anymore. Adam, bz, could you please review?

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Alec would probably also be a good reviewer.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 137958 [details] [diff] [review]
Get rid of some code

looks reasonble.  sr=bzbarsky

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Can you review this Alec?  I'll not request r= from you directly since it's not
my bug...

Comment 6

[Alec Flett]

Comment on attachment 137958 [details] [diff] [review]
Get rid of some code

nice - just make sure nsISHEntry isn't frozen.

And assuming it is not frozen, make sure to rev the IID for the interface
before landing.

Comment 7

[Alec Flett]

er nsISHTransaction I guess, not nsISHEntry - in any case, always rev the IID
when you change an interface.

Comment 8

[Harshal Pradhan]

Checked in with nsISHTransaction IID change. (And yes, I had already checked
that it was not frozen.)

Thanks for the reviews. (And thanks to stephend for the reminder, I had
forgotten I that I needed to poke someone for this review.)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR.