229401 - M17rc1 Crash while importing address book from OL 2000 - [@ nsOutlookMail::CreateList]

Status: VERIFIED FIXED

(MailNews Core :: Import, defect)

Description

[Tom Maddox]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031208

When I attempt to import the address book from Outlook 2000, Mozilla crashes.  

Reproducible: Always

Steps to Reproduce:
1. In Mozilla Mail, go to Tools->Import->Address Books.
2. Select Outlook.
3. Crash.

Actual Results:  
Windows reports that the application has crashed and creates a logfile of the
crash report.

Expected Results:  
Imported the address book from Outlook.

This is on Windows 2000 SP4 with latest critical updates, Office 2000 SR3 with
latest updates.  Using the Pinball theme in Mozilla.

Comment 1

[Tom Maddox]

Attachment: Doctor Watson logfile

The most recent log file from Dr. Watson after this crash.

Comment 2

[David :Bienvenu]

does this happen with every outlook address book, or just yours? I don't have
outlook 2000, so I can't try this. What if you make a simple address book with
just one entry, and try to import it? If that also crashes, perhaps you could
attach that address book...

Comment 3

[Tom Maddox]

When you tell Mozilla to import an address book from Outlook, what file(s) does
it look at?  Is it looking at the outlook.pst file or some other file?

Comment 4

[David :Bienvenu]

I don't know, actually. I seem to remember that Outlook does stick everything in
one giant file, so that could be it. But that would include all your e-mail
messages, everything, I think...

Comment 5

[Tom Maddox]

Right, Outlook keeps its info in a file typically called outlook.pst.  There is,
however, an external Address Book application used by Outlook and Outlook
Express, and I'm curious to know if Mozilla is trying to read the PST file or
the Address Book file.  Unfortunately, I lack the knowledge to go through the
Mozilla code and figure it out myself, but perhaps I'll take a whack at it with
a debugger tomorrow.

Comment 6

[David :Bienvenu]

Looking at the code, it looks like we use MAPI to get the address books from
Outlook (so that means it's up to Outlook as to where the AB's come from). That
also means that Outlook must be registered as the default e-mail handler while
you're importing Outlook AB's. Is Outlook registered as the default e-mail
client? We shouldn't crash in any case, but we should also put up a descriptive
error message if Outlook isn't the default MAPI client.

Comment 7

[Tom Maddox]

Outlook ought to be my default mail handler.  I switched the default to Mozilla
Mail, then opened Outlook, which caused it to prompt me to make it the default.

Comment 8

[David :Bienvenu]

If you can build and debug the code, then we'll know the stack trace of the
crash and it ought to be easy enough to fix.

Comment 9

[Bob Phillips]

Not sure if this is the right way to report it - but happened to me too, also
using OL2000 on a Win2k system, with OL as the default email application.

Workaround - I had Outlook Express installed too, which was set to
'share outlook addressbook', and I did an import to Mozilla from that without a
problem.

Hope this helps

Comment 10

[Jim Fekete]

I'm having the same problem with Outlook 2000 SP-3 and Win 98SE.  When trying to
import Outlook address book, it gets about 9/10 of the way finished (as reported
by the status bar, then crashes.  I successfully imported my mail files and my
IE bookmarks.  I was able to import my Outlook Express address book.

Comment 11

[Asa Dotzler [:asa]]

bienvenu, there are lots of reports of crashes importing from Outlook in
talkback. The stack looks like this:

nsOutlookMail::CreateList
[/mozilla/mailnews/import/outlook/src/nsOutlookMail.cpp, line 1081]
nsOutlookMail::ImportAddresses
[/mozilla/mailnews/import/outlook/src/nsOutlookMail.cpp, line 1012]
ImportOutlookAddressImpl::ImportAddressBook
[/mozilla/mailnews/import/outlook/src/nsOutlookImport.cpp, line 627]
ImportAddressThread [/mozilla/mailnews/import/src/nsImportAddressBooks.cpp, line
927]
_PR_NativeRunThread()
_PR_MD_CREATE_THREAD()
msvcrt.dll + 0x27fb8 (0x77c37fb8)
kernel32.dll + 0x1d33b (0x77e7d33b)

These crashers are reported on win98, win2k, and winXP. 

Comment 12

[Asa Dotzler [:asa]]

It's suggested in bug 226176 that this is specific to importing ABs with
distribution lists. 

Comment 13

[David :Bienvenu]

without having a copy of outlook, this is very hard  for me to recreate the
problem. I can try faking it out since it uses MAPI...

Comment 14

[David :Bienvenu]

it uses mapi 1.0, not mapi 0 (duh), so I can't even fake this...I really need a
copy of outlook to debug this, or help from someone who does.

Comment 15

[David :Bienvenu]

I tried a simple case of a contact and a distribution list, and didn't have a
problem. If anyone wants to e-mail me their Outlook.pst file, I have Outlook
now, so I can try it. I think you can export your address book to a pst file, so
you don't have to send me your whole outlook data file, but just the address
book. Thx.

Comment 16

[David :Bienvenu]

Attachment: proposed fix

I was able to recreate the crash by creating an empty distribution list - this
fixes the crash for me.

Comment 17

[Scott MacGregor]

Comment on attachment 147345 [details] [diff] [review]
proposed fix

Let's take this on the 0.6 branch for tomorrow's respin if we can.

Comment 18

[David :Bienvenu]

Comment on attachment 147345 [details] [diff] [review]
proposed fix

simple null check.

Comment 19

[David :Bienvenu]

fixed on trunk and tbird .6 branch

Comment 20

[chris hofmann]

Comment on attachment 147345 [details] [diff] [review]
proposed fix

a=chofmann for 1.7

Comment 21

[David :Bienvenu]

fixed 1.7

Comment 22

[Jay Patel [:jay]]

*** Bug 242002 has been marked as a duplicate of this bug. ***

Comment 23

[Jay Patel [:jay]]

Adding Talkback info from duped bug for tracking.

Comment 24

[Karen Huang]

Verified as fix on the lastest Mozilla nightly 06-15 build.

Comment 25

[Karen Huang]

This has been marked as verified since verification has been done for both 1.7
branch & trunk 06-15 builds