229450 - JavaScript strict warning: mailWindowOverlay.js line 403: redeclaration of var msgFolder

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Karsten Düsterloh]

JavaScript strict warning: chrome://messenger/content/mailWindowOverlay.js line
403: redeclaration of var msgFolder

This warning is currently hidden by bug 229437, but the problem is there
nonetheless. :)

Comment 1

[Karsten Düsterloh]

Attachment: Just renaming the var

To keep the context visible I just renamed the variable.
(Actually, since JS only knows two scopes (global or function level), the |var|
keyword is superfluous here.)

Comment 2

[[e-mail]]

Comment on attachment 137987 [details] [diff] [review]
Just renaming the var

This looks ugly. Would you mind inlining the call instead i.e. not using a
temporary variable?

Comment 3

[Karsten Düsterloh]

Attachment: Merge both var definitions [Checked in: Comment 4]

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 138010 [details] [diff] [review]
Merge both var definitions
[Checked in: Comment 4]


Check in: { 12/28/2003 07:51	neil%parkwaycc.co.uk	1.178 }

Comment 5

[Karsten Düsterloh]

Taking the blame. Sorry for bugspam.