Closed
Bug 229451
Opened 22 years ago
Closed 21 years ago
pref-notifications.xul should have more IDs
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ilya.konstantinov+future, Assigned: ilya.konstantinov+future)
Details
Attachments
(1 file, 2 obsolete files)
|
1.54 KB,
patch
|
Details | Diff | Splinter Review |
pref-notifications.xul, in its current form, is impossible to extend with
overlays due to key elements missing IDs.
One might wish to extend it if he implements a different biff component (as have I).
|
Assignee | |
Comment 1•22 years ago
|
||
This patch adds IDs to key elements in the pref-notifications.xul pref page
(located in messenger/content/).
|
|
Assignee | |
Updated•21 years ago
|
Attachment #137988 -
Attachment description: Patch → Patch (adds the IDs which I miss)
Attachment #137988 -
Flags: superreview?(mscott)
Attachment #137988 -
Flags: review?(mscott)
|
|
||
Comment 2•21 years ago
|
||
Comment on attachment 137988 [details] [diff] [review]
Patch (adds the IDs which I miss)
assuming this patch is still valid. Looks like it was made in 2003. Don't know
if it still applies.
Attachment #137988 -
Flags: superreview?(mscott)
Attachment #137988 -
Flags: superreview+
Attachment #137988 -
Flags: review?(mscott)
Attachment #137988 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Updated to merge with the trunk.
Assignee: sspitzer → mozilla-bugzilla
Attachment #137988 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•21 years ago
|
Attachment #150749 -
Flags: superreview?(mscott)
Attachment #150749 -
Flags: review?(mscott)
|
|
||
Updated•21 years ago
|
Attachment #150749 -
Flags: superreview?(mscott)
Attachment #150749 -
Flags: superreview+
Attachment #150749 -
Flags: review?(mscott)
Attachment #150749 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Please merge this patch before it bitrots again.
Attachment #150749 -
Attachment is obsolete: true
|
|
||
Comment 5•21 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
OS: Linux → All
Resolution: --- → FIXED
|
||
Comment 6•21 years ago
|
||
1.8 Stefan.Borggraefe%gmx.de Jun 18 05:21 Bug 229451: pref-notifications.xul
should have more IDs
Patch by Ilya Konstantinov
r=mscott, sr=mscott
Status: RESOLVED → VERIFIED
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
Component: MailNews: Notification → MailNews: Message Display
QA Contact: stephend → search
You need to log in
before you can comment on or make changes to this bug.
Description
•