229476 - about:cache title capitalization inconsistent

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[Jeremy M. Dolan]

Number of entries: 	457
Maximum storage size: 	8192 KiB
Storage in use: 	5402 KiB
Inactive Storage: 	4328 KiB

Here, "Inactive Storage" has its second word capitalized. None of the others do.

And for individual entries:

           Key: http://graphics7.nytimes.com/images/2003/12/26/...
     Data size: 151800 Bytes
   Fetch count: 3
 Last Modified: Fri Dec 26 15:45:25 2003
       Expires: Fri Dec 26 17:57:34 2003

Last Mod'd is double-cap'd, and nothing else.

Also, "Bytes" being capitalized looks silly, being not a title and mid-"sentence".

I'll attach a patch for this minor issue.

Comment 1

[Jeremy M. Dolan]

Attachment: Make capitalization consistent - Table headers as titles (All major words cap'd)

Someone can double check with an English prof that the preposition 'of' should
remain lowercase but the "In" should be capitalized because it is functioning
as an adverb in this case. I've never been good with the whole sentence
labeling thing. Either way this is a definite improvement. Reads and looks much
better.

Comment 2

[Jeremy M. Dolan]

Darin, bz, since you two just reviewed another minor "about:cache" change
elsewhere, I though you could take a quick look at this one. -thanks

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138005 [details] [diff] [review]
Make capitalization consistent - Table headers as titles (All major words cap'd)

Please set review flags if you want reviews....

r=bzbarsky

Comment 4

[timeless]

Comment on attachment 138005 [details] [diff] [review]
Make capitalization consistent - Table headers as titles (All major words cap'd)

I disagree with all of your choices except "bytes"

consider
http://landfill.mozilla.org/mxr-test/seamonkey/search?string=+in+&find=dtd&filt
er=
ignore calendar since it's almost always wrong.

15:22 < stephend> NEVER
15:22 < stephend> capitalize In
15:22 < stephend> prepositions, never.


I'd rather
"Sentence style capitalization."

Comment 5

[Jeremy M. Dolan]

Attachment: lowercase extra words

I think this looks significantly worse, especially for the entry listings which
are right-aligned, but whatever, I'll settle for any form of consistency.

Besides, this way I can blame timeless.

Comment 6

[Boris Zbarsky [:bzbarsky]]

timeless can't sr, so it's no use asking him for sr...

This needs moa from darin in any case, like I requested; I won't even bother
looking at the changes till darin OKs them -- it's just a waste of my time as
the first patch showed.

Comment 7

[Jeremy M. Dolan]

Comment on attachment 138005 [details] [diff] [review]
Make capitalization consistent - Table headers as titles (All major words cap'd)

If he can't sr +, he shouldn't sr -.

Comment 8

[Darin Fisher]

Comment on attachment 138184 [details] [diff] [review]
lowercase extra words

i vote for "Sentence style capitalization" .. i think it's plenty clear.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138184 [details] [diff] [review]
lowercase extra words

r=bzbarsky

Comment 10

[Jeremy M. Dolan]

checked in. thanks.

Comment 11

[Alexey Chernyak]

Comment on attachment 138184 [details] [diff] [review]
lowercase extra words

-    mBuffer.Append("\n<b>     Data size: </b>");
+    mBuffer.Append("\n<b>     Data size:</b>");

Umm, you removed formatting in preformatted text. Those spaces were there for a
reason.

Though perhaps a space after </b> instead of before it would of been more
sensible.

Comment 12

[Jeremy M. Dolan]

Right you are, Alexey. The fields at the top are in table cells, and they also
had the extra space after the colon. I only meant to trim it off of those. Filed
bug 239149, and I'll make a patch tomorrow. This bug (capitalization) is fixed.