229583 - Default value for mLineHeight incorrect in nsScrollPortView

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P1)

Description

[Asko Tontti]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20031221
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20031221

According mozilla/view/public/nsIScrollableView.h default height for mLineHeight
should be 12 points but now it is initialized to zero (0).

  /**
   * Set the height of a line used for line scrolling.
   * @param aHeight new line height in app units. the default
   *        height is 12 points.
   * @return error status
   */
  NS_IMETHOD SetLineHeight(nscoord aHeight) = 0;

Normally this wouldn't be problem but I am writting XUL app that uses style

  overflow: -moz-scrollbars-none

which seems to inhibit nsScrollPortView::SetLineHeight() calls for the view
in question so nsScrollPortView:ScrollByLines() doesn't work as expected
(no scrolling at all).

I have made a patch that initializes mLineHeight to 12 points as
nsScrollableView.h is documenting.

Reproducible: Always

Steps to Reproduce:


Actual Results:  
Incorrect value (0) for mLineHeight.

Expected Results:  
Default value (12 points) [or line height of applicable font].

Tested with own CVS build (trunk 2003122103 and 2003122302).

Comment 1

[Asko Tontti]

Attachment: Initialize mLineHeight to 12 points

Comment 2

[Boris Zbarsky [:bzbarsky]]

Asko Tontti, you need to ask for review from a specific reviewer (I recommend
   	[e-mail] in this case).  Otherwise, no one will get the review
request....

Comment 3

[Asko Tontti]

Comment on attachment 138068 [details] [diff] [review]
Initialize mLineHeight to 12 points

BZ, thanks for the tip.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 138068 [details] [diff] [review]
Initialize mLineHeight to 12 points

Looks reasonable. Do you want me to check it in?

Comment 5

[Asko Tontti]

roc: yes, that would be nice.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 7

[Asko Tontti]

Thanks.