229684 - application/octet-stream should have better description

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Hixie (not reading bugmail)]

In:
http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/nsExternalHelperAppService.cpp#342
...we hardcode the description of application/octet-stream to "Binary
Executable". This is inaccurate. It would be better to have it described as
something like "Binary data or executable" or just "Binary file". (It also seems
weird that this would depend on a per-platform basis -- the user's platform
surely doesn't in any way affect the type of the file...)

Comment 1

[Hixie (not reading bugmail)]

".com" should presumably also be a "binary" extension, while we're at it.

Comment 2

[Boris Zbarsky [:bzbarsky]]

.bin files on mac are typically binhex files, which the OS knows how to handle.
 On Windows, they are typically actual binary files.  Life is hard like that.  ;)

biesi, do you have time to write up a small patch for this?  It'd be good to fix
this in 1.7a....

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

this patch uses "Binary File".

also, this patch contains a fix for the following bug: (I didn't feel like
doing it in a separate bug, with a separate patch, separate reviews etc)
If the OS has info for a type, but prefs contain neither info via type nor via
ext, we would get the mimeinfo from extras.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch, also add "com" as extension

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138138 [details] [diff] [review]
patch, also add "com" as extension

Looks good.  r+sr=bzbarsky

I'm not sure whether "Binary data" or "Binary file" is better; I get "Binary
file" is fine.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.236; previous revision: 1.235
done