Closed
Bug 229730
Opened 21 years ago
Closed 21 years ago
change NS_IF_ADDREF to NS_ADDREF in nsNativeScrollbarFrame::FindScrollbar
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
1.55 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
159 if (currContent && currContent->Tag() == nsXULAtoms::scrollbar) {
160 *outContent = currContent;
161 *outFrame = start;
162 NS_IF_ADDREF(*outContent);
currContent can't be null on 160 because of 159, therefore *outContent can't be
null on 162.
Attachment #138190 -
Flags: superreview?(dbaron)
Attachment #138190 -
Flags: review?
Comment on attachment 138190 [details] [diff] [review]
NS_IF_ADDREF => NS_ADDREF; optionally discard a float => int warning
r+sr=dbaron if you use construction-style casts
Attachment #138190 -
Flags: superreview?(dbaron)
Attachment #138190 -
Flags: superreview+
Attachment #138190 -
Flags: review?
Attachment #138190 -
Flags: review+
checked in
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•