Closed Bug 229760 Opened 21 years ago Closed 21 years ago

add microsoft-cp125x font support to Gtk/Xlib

Categories

(Core Graveyard :: GFX: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jshin1987, Assigned: jshin1987)

Details

(Keywords: intl)

Attachments

(1 file, 1 obsolete file)

XFree86 freetype module present truetype fonts as X11 fonts with microsoft-cp125x (where x=1,2,3,5,7,0) if fonts support them. Adding them to Gtk/Xlin will help when web pages with characters outside iso-8859-x ranges (but covered b windows-125x) are viewed. BTW, what XLFD registry-encoding pairs does Solaris use for them?
Jungshik Shin wrote: > what XLFD registry-encoding pairs does Solaris use for them? My old Solaris 2.8 build machine (no new OS patches since a year... ;-(( - newer 2.8 releases and 2.9/2.10 support more encodings) supports the following XLFD encodings: -- snip -- % cat lib/X11/fonts/TrueType/ttmap/ttmaps.dir | fgrep FROM-ENC | sort | awk "{ print \$2 }" 78-EUC-H 78-EUC-V 78-H 78-RKSJ-H 78-RKSJ-V 78-V 78ms-RKSJ-H 78ms-RKSJ-V 83pv-RKSJ-H 90ms-RKSJ-H 90ms-RKSJ-V 90pv-RKSJ-H 90pv-RKSJ-V Add-H Add-RKSJ-H Add-RKSJ-V Add-V Adobe-CNS1-0 Adobe-GB1-1 Adobe-GB1-2 Adobe-GB1-4 Adobe-Japan1-0 Adobe-Japan1-1 Adobe-Japan1-2 Adobe-Japan1-2 Adobe-Japan2-0 Adobe-Japan2-0 Adobe-Korea1-1 ansi-1251 B5-H B5-V B5pc-H B5pc-V big5-1 CNS-EUC-H CNS-EUC-V CNS1-H CNS1-V cns11643-1 cns11643-2 cns11643-3 CNS2-H CNS2-V dingbats-1 ETen-B5-H ETen-B5-V EUC-H EUC-V Ext-H Ext-RKSJ-H Ext-RKSJ-V Ext-V gb18030.2000-0 gb18030.2000-1 gb2312.1980-0 gbk-0 H Hankaku Hiragana Hojo-EUC-H Hojo-EUC-V Hojo-H Hojo-V iso8859-1 iso8859-13 iso8859-15 iso8859-2 iso8859-4 iso8859-5 iso8859-6 iso8859-6.8x iso8859-7 iso8859-8 iso8859-9 jisx0201.1976-0 jisx0201.1976-0 jisx0208.1983-0 jisx0208.1983-0 jisx0212.1990-0 jisx0212.1990-0 Katakana koi8-r ksc5601.1987-0 ksc5601.1992-3 NWP-H NWP-V RKSJ-H RKSJ-V Roman sun-fontspecific suneu-greek tis620.2533-0 V WP-Symbol -- snip --
Hey, you just made it hard to read this bug with that not-so-useful-long [1] list. At least you had to convert newlines to spaces (or commas) at the end of your filter chain. Besides, the list didn't answer my question at all. I know Solaris supports Windows-1251 (for Russian) so that there must be fonts, but your snipped list doesn't have it. [1] Most of them are CID-keyed font encoding names.
I found 'ansi-1251' in the list and it's probably for Windows-1251. Mozilla already has 'ansi-1251'. Why don't you filter your list with 'egrep 125[0-9]' instead of snipping?
Attached patch patch (obsolete) — Splinter Review
In this patch, I'm adding microsoft-cp125x (where x = 0, 2, 3, 7). microsoft-cp1251 (for Cyrillic) has been in the tree for a while. I'm not adding 1255 and 1256 because it's not clear how they can be used for Hebrew and Arabic. I also changed FLG (font langGroup) of ISO-8859-4/13 to Baltic from Western Europe. Currently, it has little effect because Gtk/Xlib get that information from charsetData.properties file that I wanna change in bug 215537.
Attachment #138270 - Attachment is obsolete: true
Comment on attachment 138271 [details] [diff] [review] patch with '1252' association error fixed asking for r/sr. this is a trivial fix.
Attachment #138271 - Flags: superreview?(rbs)
Attachment #138271 - Flags: review?(Roland.Mainz)
Comment on attachment 138271 [details] [diff] [review] patch with '1252' association error fixed Due lack of a tree I didn't tested the patch but I trust jshin that he tested it on his side... ... patch looks OK and is short...so... r=Roland.Mainz@informatik.med.uni-giessen.de :)
Comment on attachment 138271 [details] [diff] [review] patch with '1252' association error fixed Due lack of a tree I didn't tested the patch but I trust jshin that he tested it on his side... ... patch looks OK and is short...so... r=Roland.Mainz@informatik.med.uni-giessen.de :)
Attachment #138271 - Flags: review?(Roland.Mainz) → review+
Jungshik Shin wrote: > Hey, you just made it hard to read this bug with that not-so-useful-long [1] > list. At least you had to convert newlines to spaces (or commas) at the end of > your filter chain. My fault... I simply pasted the terminal output without thinking about the consequences... ;-/ > Besides, the list didn't answer my question at all. I know > Solaris supports Windows-1251 (for Russian) so that there must be fonts, but > your snipped list doesn't have it. Solaris AFAIK uses the iso8859-* encodings to cover european locales, russian is supported via both ansi-1251 and koi-* (yes, even two seperate locales are available for that :) , but the other windows-12?? font encodings do not seem to have counterparts in Solaris (and I guess the hell will freeze before Sun creates files beginning with "windows-" in /usr ... =:-) ... maybe more encodings will be supported in Solaris 2.10 (or not... since the whole XLFD+Xft stuff is being replaced/superset by STSF anyway).
Comment on attachment 138271 [details] [diff] [review] patch with '1252' association error fixed sr=rbs
Attachment #138271 - Flags: superreview?(rbs) → superreview+
thanks for r/sr. fix checked into the trunk this will help cases like bug 226758.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: