229783 - Download which tries to overwrite read-only file doesn't fail until download is complete

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Jan Magne Landsvik]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5) Gecko/20031015 Firebird/0.7
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5) Gecko/20031015 Firebird/0.7

When downloading and saving a file onto a file with same name, and the existing
file is ReadOnly, then FireBird does NOT give a warning, but fails to save,
AFTER downloading the whole file.

Reproducible: Always

Steps to Reproduce:
1.Download a file.
2.Set file ReadOnly.
3.Download same file into same file/folder.

Actual Results:  
The file downloads, and after finishing download says: PATH\FILE\could not be
saved, because you cannot change the content of that folder.
Change the folder properties and try again, or save in a different location.

Expected Results:  
Give a notice that the file is ReadOnly BEFORE starting the download!

Comment 1

[Jan Magne Landsvik]

Operating System: OS/2 Warp Server for eBussiness (4.50)

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

Add our own message for readonly since other file dialogs do it.

Comment 3

[Mike Kaply [:mkaply]]

taking

Comment 4

[jhp (no longer active)]

Comment on attachment 138428 [details] [diff] [review]
Fix for problem

Is there a way to not persist the three char strings?

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Better fix

This patch makes the strings global and static so they only get allocated once
and they only get allocated as needed.

Comment 6

[Mike Kaply [:mkaply]]

changing product

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 138431 [details] [diff] [review]
Better fix

sr=blizzard (platform specific)
a=mkaply for 1.4.2 and 1.6 since it is OS/2 specific

Comment 8

[Mike Kaply [:mkaply]]

Fixed everywhere