Closed Bug 229818 Opened 21 years ago Closed 21 years ago

Search/Subscribe should use start/stopMeteors

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: sspitzer)

References

Details

Attachments

(1 file, 1 obsolete file)

Search too
5.81 KB, patch
sspitzer
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
The to fix bug 47909 has a separate patch because subscribe does things its own way, so I suggest reusing code... another useful effect of which is to make the stop button disable and enable as appropriate.
Attached patch Proposed patch (obsolete) — — Splinter Review
Attachment #138233 - Flags: superreview?(bienvenu)
Attachment #138233 - Flags: review?(mscott)
Comment on attachment 138233 [details] [diff] [review] Proposed patch looks good to me.
Attachment #138233 - Flags: superreview?(bienvenu) → superreview+
Might as well do Advanced Search too.
Summary: Subscribe should use start/stopMeteors → Search/Subscribe should use start/stopMeteors
Attached patch Search too — — Splinter Review
Attachment #138251 - Flags: superreview?(bienvenu)
Attachment #138251 - Flags: review?(sspitzer)
Comment on attachment 138251 [details] [diff] [review] Search too looks OK to me - however, it's possible Seth did what he did for a reason, so he will get the final word :-)
Attachment #138251 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 138251 [details] [diff] [review] Search too r=sspitzer, assuming changing the id on the stop button doesn't break anything. (nothing is looking for cmd_stop, right?)
Attachment #138233 - Attachment is obsolete: true
Attachment #138233 - Flags: review?(mscott)
Comment on attachment 138251 [details] [diff] [review] Search too r=sspitzer for real.
Attachment #138251 - Flags: review?(sspitzer) → review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
weird, with this change, the subscribe dialog in thunderbird doesn't load any folders (for imap) or newsgroups for news. No JS errors. Backing out just the change to subscribe.js makes it all work again. Neil, can you think of any other checkins your new code may be relying on? the only forked file in this checkin is subscribe.xul and I ported that change over
Perhaps TB's subscribe.xul is not including one of Mozilla's JS files?
Product: Browser → Seamonkey
Component: MailNews: Subscribe → MailNews: Message Display
QA Contact: stephend → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: