22986 - Address book sort is extremely slow

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Richard Zach]

Sorting an address book with 250 cards takes almost 30 sconds on my 400MHz K6-2
with 128MB, running RH 6.0 and Linux build 2000.01.02.09.

While sorting, the console continuously outputs
nsCollationUnix::Initialize mLocale = C
which is only output once when I do a sort in the message pane.

Comment 1

[hangas]

Sending bug to Candice for investigation.  I am not sure that the problem is in
address book code, but it seems like a good place to start.  cc'ing Putterman
Alec in case one of them has some insight into this.

Comment 2

[scottputterman]

It looks like we might be caching something in mail that is being created
multiple times in the address book? cc'ing David and Naoki.

Comment 3

[scottputterman]

It looks like we might be caching something in mail that is being created
multiple times in the address book? cc'ing David and Naoki.

Comment 4

[nhottanscp]

I think the collation object needs to be cached.
In nsAbCardProperty::GetCollationKey, looks like the collation object is
generated for each collation key. We can generate the collation object once per
address book then only needs to call CreateSortKey per key generation.

Comment 5

[David :Bienvenu]

yes, I agree with Naoki. The collation object should be cached.

Comment 6

[leger]

Bulk add of "perf" to new keyword field.  This will replace the [PERF] we were
using in the Status Summary field.

Comment 7

[Phil Peterson]

Wouldn't hold beta1 for this, but it would be nice to have.

Comment 8

[chuang]

Fix checked in.

Comment 9

[Richard Zach]

Verified fixed on Linux build 2000.02.13.08