229897 - Fix 'Suggest parentheses around assignment used as truth value' 'Blamed Build Warnings; Linux brad Clobber'

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Serge Gautherie (:sgautherie)]

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) </gfx/src/nsRegionImpl.cpp>

Patch for

{ mkaply
1.	gfx/src/nsRegionImpl.cpp:138 (See build log excerpt)
	Suggest parentheses around assignment used as truth value

136 const nsRect* pSrc;
137 
138 while (pSrc = ri.Next ())
139 {
140   pDest->x = pSrc->x;
}

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 138277 [details] [diff] [review]
(Av1) </gfx/src/nsRegionImpl.cpp>


'r=?': (see comment 1)
I have no compiler: Could you compile/test/review it ? Thanks.

Comment 3

[Serge Gautherie (:sgautherie)]

There are also these:

{ Unblamed
36.	dirver.c:132 (no file match) (See build log excerpt)
	Suggest parentheses around assignment used as truth value
37.	dirver.c:135 (no file match) (See build log excerpt)
	Suggest parentheses around assignment used as truth value
40.	dirver.c:81 (no file match) (See build log excerpt)
	Suggest parentheses around assignment used as truth value
41.	dirver.c:84 (no file match) (See build log excerpt)
	Suggest parentheses around assignment used as truth value
42.	dirver.c:87 (no file match) (See build log excerpt)
	Suggest parentheses around assignment used as truth value
}

{
mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:
In function `_GetVersions':
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:81:
warning: suggest parentheses around assignment used as truth value
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:84:
warning: suggest parentheses around assignment used as truth value
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:87:
warning: suggest parentheses around assignment used as truth value
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:
In function `_GenBuildDate':
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:132:
warning: suggest parentheses around assignment used as truth value
/mnt/4/tinderbox/brad/Linux_2.4.23backupboy-1_Clobber/mozilla/directory/c-sdk/ldap/build/dirver.c:135:
warning: suggest parentheses around assignment used as truth value
}

But how to retrieve </directory/c-sdk/ldap/build/dirver.c> to prepare a patch ?

Or how to get rid of it from the build ?
{ mozilla/ directory/ c-sdk/ ldap/ build/ Attic/ dirver.c (5.1)
5.1	mcs%netscape.com	Apr 17 2002	 	Remove dirver.c and Makefile.client
references to it (no longer used).
}

Or may be the v5.1 "failed"
{
MXR: dirver.c | 5.0 | Tldapcsdk_50_client_branch
}

Comment 4

[Boris Zbarsky [:bzbarsky]]

I think:

  if ((foo = bar()) != nsnull)

is preferable to

  if ((foo = bar()))

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av1b) </gfx/src/nsRegionImpl.cpp> [Checked in: Comment 9]

Av1, with comment 4 suggestion(s).

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 138334 [details] [diff] [review]
(Av1b) </gfx/src/nsRegionImpl.cpp>
[Checked in: Comment 9]


'r=?': (see comment 1)
I have no compiler: Could you compile/test/review it ? Thanks.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 138334 [details] [diff] [review]
(Av1b) </gfx/src/nsRegionImpl.cpp>
[Checked in: Comment 9]

okay

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

reassigned to myself for checkin

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 10

[Serge Gautherie (:sgautherie)]

Fixed !? Only one of the two reported files...

What about comment 3 <dirver.c> ?
(Still there in "Linux brad Clobber (info) on 02/20 17:58")

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Or may be the v5.1 "failed"
> {
> MXR: dirver.c | 5.0 | Tldapcsdk_50_client_branch
> }

MXR still finds this file in mozilla1.8 tree,
but not in mozilla one anymore... :-)