229913 - Remove unused defaultengine.label from pref-search.dtd

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031209
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031209

Bug 225490 removed Netscape Search from Mozilla, but apart from what is
mentioned in bug 225490 comment #44 there is one more line that still mentions
Netscape search:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/locale/en-US/pref-search.dtd#14
saying:
<!ENTITY  defaultengine.label             "Netscape Search">

It turned out that this entity is not used anymore, so it should be removed. For
a more detailed analysis where this came from and why it survived, please read
on. If the above is sufficient for you... that's been all.


Detailed research:
This string was put there in version 1.4 of pref-search.dtd, a few hours after
the search-pref panel was introduced.

Later it was changed from "(default)" to "Netscape Search" in version 1.8 of
pref-search.dtd, fixing bug 26931. Access to that bug is restricted, but not
because of security reasons, maybe there are some Netscape interna in it? The
fix at least seems harmless: bonsai says that additionally in pref-offline.dtd
some occurences of "Communicator" were changed to "Mozilla", that's it.

The only place that used it was pref-search.xul. Beginning with version 1.14
("pref window IV landing") it was no more used, but nevertheless not removed.

Lxr does not find any other usage and it seems quite obvious that it has just
been forgotten and is not in use even by any extension or Netscape 7 (actually I
checked its search prefs and it does not appear there).

The other strings in pref-search.dtd are all still in use.

Patch coming.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Andreas Kunz]

Attachment: Patch: remove that string

This is the fix, I compiled and tested it.

Comment 2

[Andreas Kunz]

Comment on attachment 138296 [details] [diff] [review]
Patch: remove that string

Requesting r= from Neil and sr= from alecf.

I forgot: thanks to KaiRo for spotting that string!

Comment 3

[[e-mail]]

Hmmm... this entry would still work if you restored it...

Comment 4

[[e-mail]]

Comment on attachment 138296 [details] [diff] [review]
Patch: remove that string

OK, so I've since discovered that having a "use default" type menuitem is
inappropriate.

Comment 5

[Alec Flett]

Comment on attachment 138296 [details] [diff] [review]
Patch: remove that string

sr=alecf

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpfe/components/prefwindow/resources/locale/en-US/pref-search.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-search.dtd,v
 <--  pref-search.dtd
new revision: 1.20; previous revision: 1.19
done

Comment 7

[Andreas Kunz]

v