Closed
Bug 229962
Opened 21 years ago
Closed 21 years ago
charset parameter in attached vCards should be utf-8, not utf8
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla.org, Assigned: sspitzer)
References
()
Details
(Keywords: helpwanted, verified1.7, Whiteboard: [good first bug])
Attachments
(1 file)
772 bytes,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
asa
:
approval1.7+
|
Details | Diff | Splinter Review |
Mozilla (as of Thunderbird 0.4) sends attached vCards with
Content-Type: text/x-vcard; charset=utf8;
The charset parameter should be "utf-8" with a hyphen.
See ftp://ftp.rfc-editor.org/in-notes/std/std63.txt
Summary: charset parameter in attached vCards should be utf-8 (hyphen) → charset parameter in attached vCards should be utf-8, not utf8
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#1083
That's the only lxr match containing 'charset=utf8;'
I don't have the knowledge to compile and test this, but there's the patch
nonetheless.
Comment 3•21 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.6) Gecko/20040113
-> encodes the personal vCard file with "charset=utf8;" and 7bit
content-transfer-encoding, which it is able to import;
-> doesn't add any charset info for attached vCards, exported by Palm Desktop
4.0.1, uses 8bit content-transfer-encoding and is not able to import this (nor
even tries to; my vCard file I appended contained many addresses)
Keywords: helpwanted
Whiteboard: [good first bug]
Comment 4•21 years ago
|
||
Scott, can you take a look at this?
Updated•21 years ago
|
Attachment #140011 -
Flags: superreview+
Attachment #140011 -
Flags: review?(bienvenu)
Updated•21 years ago
|
Attachment #140011 -
Flags: review?(bienvenu) → review+
Comment 6•21 years ago
|
||
Comment on attachment 140011 [details] [diff] [review]
change utf8 to uft-8
a=asa (on behalf of drivers) for checkin to 1.7
Attachment #140011 -
Flags: approval1.7+
Comment 7•21 years ago
|
||
not going to block the release for this but if someone has the time to check it
into the branch, we'll take it.
Flags: blocking1.7? → blocking1.7-
Comment 9•21 years ago
|
||
Now displaying -> Content-Type: text/x-vcard; charset=utf-8;
Verified as fix on latest 1.7 branch 06-24 builds.
Changing keywords from fixed1.7 to verified1.7.
Leave this bug status "as is" until this bug be verified on trunk again...
Keywords: fixed1.7 → verified1.7
Updated•21 years ago
|
Product: MailNews → Core
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•