Closed Bug 229993 Opened 21 years ago Closed 21 years ago

x-jsd: urls should not go into history

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Product:
Other Applications Graveyard
Component:
Venkman JS Debugger
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: rginda)

Details

Attachments

(1 file, 1 obsolete file)

Better patch
947 bytes, patch
rginda
: review+
Details | Diff | Splinter Review 
venkman needs to use disablehistory="true" to a) reduce footprint and b) stop
x-jsd: urls from going into global history - if you use the last page visited
prefs then they get overwritten too...
Attached patch Proposed patch (obsolete) — — Splinter Review 
I also removed a spurious line - tabpanels is a type of deck and therefore
automatically stretches its children to fit. I would have removed the spurious
<tabpanel> element completely but I didn't feel like debugging Venkman to find
out if any code depended on the element's existence.
Attachment #138353 - Flags: review?(rginda)
Attached patch Better patch — — Splinter Review 
Actually we could disable security UI too...
Comment on attachment 138354 [details] [diff] [review]
Better patch

r=rginda
Attachment #138354 - Flags: review+
Attachment #138353 - Attachment is obsolete: true
Attachment #138353 - Flags: review?(rginda)
Attachment #138354 - Flags: superreview?(bz-vacation)
venkman and chatzilla don't typically require superreview.
Comment on attachment 138354 [details] [diff] [review]
Better patch

OK, so the checkins to Venkman in the last 5 months weren't typical :-P
Attachment #138354 - Flags: superreview?(bz-vacation)
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: