230204 - IWB installer updates

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Mike Kaply [:mkaply]]

We made some changes for the installer for IBM Web Browser that should be on the
trunk.

1. Resized panels so they translate better.
2. Added the ability to find the previous install from an arbitrary INI file.
3. Fixed a bug where we had named a variable in CONFIG.INI incorrectly.
4. Added support for a new location for files - OS2SYSDIR (\\OS2\\SYSTEM)
5. Added support for objects on the desktop to be updated or to fail when trying
to create if they exist already.
6. Fixed bug where on the final summary install page we left the (~X) in for
DBCS languages.
7. Added some better comments in CONFIG.INI

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Installer changes for IWB [Checked in: Comment 2]

Comment 2

[Mike Kaply [:mkaply]]

checked in everywhere

Comment 3

[Peter Weilbacher]

Attachment: Replace all instances of strcmpi() in mozilla\xpinstall\wizard\os2\setup\ifuncns.c with stricmp() [Checked in: Comment 8]

When compiling Mozilla 1.6 yesterday I got the following error

g++ -o setup.exe  -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith
-Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-long-long
-pedantic -Zomf -pipe  -DNDEBUG -DTRIMMED -O2  setup.o extra.o ifuncns.o
logging.o xpi.o dialogs.o nsEscape.o nsINIParser.o xpnetHook.o setup.res  
-Zlinker /EXEPACK:2 -Zlinker /PACKCODE -Zlinker /PACKDATA -Zlinker /PM:PM
-L../../../../dist/bin -L../../../../dist/lib -lmozregsa_s -ljar50_s -lmozz_s
-lxpnet_s -lsocket -ldl -lm   -Zlinker /ST:0x100000   
weakld: error: Unresolved symbol '_strcmpi'.
Ignoring unresolved externals reported from weak prelinker.
G:\MozCompile\obj\xpinstall\wizard\os2\setup\ifuncns.o(ifuncns.o) : error
LNK2029: "_strcmpi" : unresolved external

after some previous warnings about strcmpi.

Is this a typo and you really wanted to use stricmp() instead? To fix this I
simply replaced all instances of strcmpi() in
mozilla\xpinstall\wizard\os2\setup\ifuncns.c with stricmp() and the compile
worked.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 138485 [details] [diff] [review]
Installer changes for IWB
[Checked in: Comment 2]

Not a "user" problem:
this '01/09/2004 14:05	mkaply%us.ibm.com' check-in made the 'OS2GCC Depend'
tinderbox turn red too:
{
weakld: error: Unresolved symbol '_strcmpi'.
Ignoring unresolved externals reported from weak prelinker.

E:\OS2_2.45_Clobber\mozilla\obj\xpinstall\wizard\os2\setup\ifuncns.o(ifuncns.o)
: error LNK2029: "_strcmpi" : unresolved external
}
:-(

Comment 5

[Serge Gautherie (:sgautherie)]

"Surprisingly", the 'OS2VACPP Dep' (MOZILLA_1_4_BRANCH) tinderbox is unaffected...
(There is no OS/2 tinderbox for MOZILLA_1_6_BRANCH.)


For the record: (I did a quick search, if relevent)

<http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=strcmpi>
(If you believe cleanup on the other files is "needed", please file another bug.)

<http://most-art.de/ctutorial/bookc1/d17.htm>
{
Comparing Two Strings While Ignoring Case

Unfortunately, the ANSI C library doesn't include any functions for
case-insensitive string comparison. Fortunately, most C compilers provide their
own "in-house" functions for this task. Symantec uses the function strcmpl().
Microsoft uses a function called _stricmp(). Borland has two
functions--strcmpi() and stricmp(). You need to check your library reference
manual to determine which function is appropriate for your compiler.
}

<http://www.oe.fau.edu/~lyann/watcom/clibref/src/stricmp.html>
{
The _stricmp() function is identical to stricmp(). Use _stricmp() for ANSI
naming conventions.
}

Comment 6

[Benjamin Smedberg]

Comment on attachment 138812 [details] [diff] [review]
Replace all instances of strcmpi() in mozilla\xpinstall\wizard\os2\setup\ifuncns.c with stricmp()
[Checked in: Comment 8]

this is mkaply's call, so MOA=bsmedberg as long as mkaply agrees.

Comment 7

[Mike Kaply [:mkaply]]

yeah my bad.

We had removed all the strcmpi for GCC and then I put them back.

I fixed this.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 138812 [details] [diff] [review]
Replace all instances of strcmpi() in mozilla\xpinstall\wizard\os2\setup\ifuncns.c with stricmp()
[Checked in: Comment 8]


Check in: { 01/11/2004 21:15	mkaply%us.ibm.com	mozilla/ xpinstall/
wizard/ os2/ setup/ ifuncns.c	    1.13 }

Comment 9

[Serge Gautherie (:sgautherie)]

Green is back on 'OS2GCC Depend on 01/11 21:20' :-)