230210 - Missing /language.accept/ line in file res/language.properties for (Upper ) Sorbian

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Michael Wolf]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; wen-DE; rv:1.6b) Gecko/20031208
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; wen-DE; rv:1.6b) Gecko/20031208

In the file res/language.properties has been removed the line *sb.accept=true*
for Sorbian because the language code (sb) wasn't valid. Unfortunately it wasn't
replaced by a line with a valid code (wen for both Sorbian languages) or hsb
(for Upper Sorbian, valid since 2003, September 1st). The missing line causes
that you can't more create a profile directly for Sorbian. It'a always necessary
to switch the from English to Sorbian by
Edit-->Preferences-->Appearance-->Languages/Content.
I propose to use "hsb" now although there isn't a Lower Sorbian localization
yet. But maybe it will future so that you can use the corresponding code dsb 
for Lower Sorbian. (see: http://www.loc.gov/standards/iso639-2/codechanges.html)
The collective code "wen" used for both Sorbian languages would disable a
separate localization for Upper resp. Lower Sorbian.   

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Andreas Kunz]

jshin, in bug 224546 you removed sb (see bug 224546 comment #15). I'm not sure
what it meant that it was missing in that other file, but obviously it was
working before removal from language.properties.
I guess you know much more about those files and can fix the problem easily.
If the fix is just to re-add the line to this one file (or similarly trivial),
I'll do the patch, just say it. Thanks.

Comment 2

[Jungshik Shin]

Attachment: patch

I added 'hsb' (Upper Sorbian) per Michael's suggestion. 

Andreas, adding back 'sb' is not an option. 'sb' has NEVER been the language
code for Sorbian.

Comment 3

[Jungshik Shin]

Comment on attachment 138859 [details] [diff] [review]
patch

asking for r/sr.

I'll fix the misalignment in the following line (the column position of 'true')

hsb.accept =	true

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 138859 [details] [diff] [review]
patch

r=smontagu

Comment 5

[Jungshik Shin]

fix checked into trunk

Comment 6

[Jungshik Shin]

I'm sorry it was too late for 1.6. I'll ask for 1.6.1 approval if 1.6.1 is planned.