230229 - remove printplus css selectors

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

/themes/classic/communicator/bookmarks/bookmarksWindow.css, line 47 -- #navprintplus
/themes/modern/communicator/bookmarks/bookmarksWindow.css, line 46 --
#navprintplus {

now that netscape is gone, I don't think we need to keep these lines in mozilla
cvs...

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) 2* <bookmarksWindow.css>, cleanup [Checked in: Comment 18]

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 138508 [details] [diff] [review]
(Av1) 2* <bookmarksWindow.css>, cleanup
[Checked in: Comment 18]


I guess it's as easy as this !?

Comment 3

[[e-mail]]

pch, can't we just get rid of these CSS files completely? I can't see that any
of this CSS is relevant.

Comment 4

[Pierre Chanial]

Neil: yep, these files can be removed.

Comment 5

[[e-mail]]

Comment on attachment 138508 [details] [diff] [review]
(Av1) 2* <bookmarksWindow.css>, cleanup
[Checked in: Comment 18]

As per comment 4.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) 2* <bookmarksWindow.css>, removal

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 139388 [details] [diff] [review]
(Bv1) 2* <bookmarksWindow.css>, removal


More like this then ? (untested)

Comment 8

[[e-mail]]

Comment on attachment 139388 [details] [diff] [review]
(Bv1) 2* <bookmarksWindow.css>, removal

You need to take
http://lxr.mozilla.org/seamonkey/source/themes/classic/communicator/bookmarks/b
ookmarksWindow.css#40 and
http://lxr.mozilla.org/seamonkey/source/themes/modern/communicator/bookmarks/bo
okmarksToolbar.css#44 into account.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 139388 [details] [diff] [review]
(Bv1) 2* <bookmarksWindow.css>, removal


The line(s) you quoted are
{
@import url("chrome://communicator/skin/bookmarks/bookmarks.css");
}

In the XUL file(s), there is
{
<?xml-stylesheet href="chrome://communicator/content/bookmarks/bookmarks.css"
type="text/css"?>
}

Oh ! My mistake:
I saw theses |/skin/| lines,
but I misread the |/content/| ones which are in the XUL files :-<
(good catch !)

(I'll update the patch...)

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1b) 2* <bookmarksWindow.css>, removal

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 139445 [details] [diff] [review]
(Bv1b) 2* <bookmarksWindow.css>, removal


That should be it !? (untested)

Comment 12

[jag (Peter Annema)]

Comment on attachment 139445 [details] [diff] [review]
(Bv1b) 2* <bookmarksWindow.css>, removal

Are you sure the other CSS in classic's bookmarksWindow.css is unused? If so,
sr=jag.

Comment 13

[Serge Gautherie (:sgautherie)]

I can only trust comment 4 on that...
{
Neil: yep, these files can be removed.
}

Comment 14

[[e-mail]]

Comment on attachment 138508 [details] [diff] [review]
(Av1) 2* <bookmarksWindow.css>, cleanup
[Checked in: Comment 18]

Ah, it turns out that the classic bookmarks sidebar needs these styles (slaps
wrist)

Comment 15

[Stephen Walker]

*** Bug 171489 has been marked as a duplicate of this bug. ***

Comment 16

[jag (Peter Annema)]

Comment on attachment 139445 [details] [diff] [review]
(Bv1b) 2* <bookmarksWindow.css>, removal

minusing this patch too, then. Perhaps we could move that CSS to another file
(bookmarks.css?) and still get rid of these files.

Comment 17

[jag (Peter Annema)]

Comment on attachment 138508 [details] [diff] [review]
(Av1) 2* <bookmarksWindow.css>, cleanup
[Checked in: Comment 18]

For now this will do.

Comment 18

[[e-mail]]

Fix checked in. pch, do you think that those Classic styles could be moved to
one of the other CSS files?