230258 - sanitize Navigator Help

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Daniel Wang]

continuing on bug 153671
update for new png images

Comment 1

[Daniel Wang]

Attachment: patch

Comment 2

[Daniel Wang]

Comment on attachment 138512 [details] [diff] [review]
patch

this must be checked in AFTER bug 107225 is fixed

Comment 3

[R.J. Keller]

yes, of course.

swapping QA/Owner

Comment 4

[R.J. Keller]

Comment on attachment 138512 [details] [diff] [review]
patch

bah. I made my review in TextPad and it crashed before I could post it :(. The
thing I remember noting was that there were a LOT (about 10) anchors that you
removed that were used in the TOC and index. You have to either not remove
those anchors, or update the TOC and index to make sure we don't have dead
links.

Comment 5

[Giacomo Magnini]

Attachment: Reviving the good parts of the patch, and more... (checked in)

I've tried to save a few good things from this outdated patch, namely the
elimination of a useless paragraph and better instructions for search in
bookmarks/history. While at it, I corrected some indentation and rewrote
(please check!) the part dealing with plugins (which was clearly too
NS-centric).

Comment 6

[Stefan [:stefanh]]

--> Giacomo.

Comment 7

[Ian Neal]

Comment on attachment 172894 [details] [diff] [review]
Reviving the good parts of the patch, and more... (checked in)

Checking in nav_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/nav_help.xhtml,v  <-- 
nav_help.xhtml
new revision: 1.47; previous revision: 1.46
done

Comment 8

[Stefan [:stefanh]]

v

Comment 9

[[e-mail]]

Comment on attachment 172894 [details] [diff] [review]
Reviving the good parts of the patch, and more... (checked in)

>-	lists are for the left, center, and right header areas. The bottom row
>-	are for the left, center, and right footer areas. In each drop-dop
>-	list, choose one of the following options:
>+        lists are for the left, center, and right header areas. The bottom row
>+        are for the left, center, and right footer areas. In each drop-dop
>+        list, choose one of the following options:
Hmm, I wonder how "drop-dop" got there. (I assume it should be drop-down.)