Closed
Bug 230264
Opened 21 years ago
Closed 21 years ago
inspector leaks
Categories
(Other Applications :: DOM Inspector, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: memory-leak, Whiteboard: [patch])
Attachments
(1 file, 1 obsolete file)
|
2.08 KB,
patch
|
Details | Diff | Splinter Review |
Using inspector causes lots of stuff to be leaked.
Patches soon...
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 138515 [details] [diff] [review]
patch
diff doesn't show this patch too well. It:
* moves DeepTreeStackItem before inDeepTreeWalker ctor/dtor
* adds ctor/dtor logging to DeepTreeStackItem
* clears out |mStack| in inDeepTreeWalker's destructor.
I realize I shouldn't have moved the inIDeepTreeWalker comment up above the
ctor/dtor/NS_IMPL_ISUPPORTS1 -- I missed the "I".
Attachment #138515 -
Flags: superreview?(bryner)
Attachment #138515 -
Flags: review?(caillon)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7alpha
|
||
Comment 3•21 years ago
|
||
Comment on attachment 138515 [details] [diff] [review]
patch
Nice. r=caillon. While you're here (and if you remember) can you make
inDeepTreeWalker's ctor use an initialization list?
Attachment #138515 -
Flags: review?(caillon) → review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
patch with caillon's comments
Attachment #138515 -
Attachment is obsolete: true
|
||
Updated•21 years ago
|
Attachment #138515 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
Fix checked in to trunk, 2004-01-07 14:17 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Other Applications
|
||
Updated•18 years ago
|
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•