230270 - presshell leaks mCurrentEventContent

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The following steps cause lots of stuff to be leaked (global object, etc.).  The
root of the leak is a reference added in PresShell::ClearFrameRefs.

Steps to reproduce:
 1. ./mozilla -P <profile name> -inspector http://dbaron.org/
 2. In the upper left tree, click "HTML"
 3. At the top of the upper right, click the dropdown and choose "CSS Style Rules"
 4. Click on the one rule.
 5. Right-click on the one property
 6. Choose "Edit" in the context menu
 7. Click "OK"
 8. close the window with the "X" in the titlebar

I'll attach a patch that fixes the leak.  I'm not really happy with the patch --
the code seems quite messy.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I didn't test which of the two changes fixes the leak, and I suspect that a
change elsewhere which maintains the invariant that either mCurrentEventContent
or mCurrentEventFrame is set, but never both, might fix it better.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's the first of the two changes that fixes the leak.

However, the second of the two changes made me read the code there a bit more
carefully, and wonder whether the whole need for the IsZombieDocument test was
because mCurrentEventContent isn't released before assigning to mCurrentEventFrame.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2004-01-07 14:18 -0800.