Closed
Bug 230434
Opened 21 years ago
Closed 21 years ago
Remove nsIPref from spellchecker
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
People
(Reporter: mikael, Assigned: mikael)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.08 KB,
patch
|
mkaply
:
review+
|
Details | Diff | Splinter Review |
nsIPref > nsIPrefService w/ friends
|
Assignee | |
Comment 1•21 years ago
|
||
I also noticed that an Observer is reg:ed for 'profile-before-change'
and 'profile-after-change' but Observe() only acts on 'profile-before-change'
Maybe the Load() should happen on 'profile-after-change'?
|
|
Assignee | |
Updated•21 years ago
|
Attachment #138647 -
Flags: superreview?(brendan)
Attachment #138647 -
Flags: review?(scc)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•21 years ago
|
Attachment #138647 -
Flags: review?(scc) → review?(dbaron)
Comment on attachment 138647 [details] [diff] [review]
proposed patch
sr=dbaron if you fix the NS_IMPL_ISUPPORTS3 macro in this file to refer to
nsISupportsWeakReference instead of nsSupportsWeakReference.
You should get review from spellcheck's owner (perhaps mkaply?).
Attachment #138647 -
Flags: superreview?(brendan)
Attachment #138647 -
Flags: superreview+
Attachment #138647 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•21 years ago
|
Attachment #139048 -
Flags: review?(mkaply)
|
||
Comment 4•21 years ago
|
||
Comment on attachment 139048 [details] [diff] [review]
new patch [checked in 040126]
r=mkaply
Attachment #139048 -
Flags: review?(mkaply) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #138647 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #139048 -
Attachment description: new patch → new patch [checked in 040126]
|
|
Assignee | |
Updated•21 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•