230466 - Saving an attachment does not bring up a stand alone progress window

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Scott MacGregor]

Select an attachment. Right click to bring up the context menu. Select SAVE (not
Open).

We prompt for a file name and the show save progress inside the main mail window.

We should really create a stand alone progress window like we do if you chose
"open".

Comment 1

[Scott MacGregor]

Attachment: first draft at a fix

Modify nsMsgSaveListener for the attachment case only, to invoke a progress
dialog (nsIDownload) and feed progress information to it. We also listen for a
cancel event from the dialog and cancel our download.

Some of the remaining issues:

1) we still show progress in the status bar of the main mail window. I don't
think we should do that but maybe it is ok.

2) If the download is a quick one (which is common for mailbox urls or small
imap attachments), we flash the progress dialog then take it down. Ideally we
shouldn't show it at all.

3) When dragging an attachment to the desktop, the dialog comes up as soon as
you initiate the drag. This is because of a drag and drop bug and not us
though.

Comment 2

[Scott MacGregor]

cc'ing Jason. This one's for him :)

Comment 3

[Scott MacGregor]

Attachment: updated patch

This patch refactors things a little differently. By delaying our attempt to
initialize the progress dialog until after the first OnDataAvailable
notifcation is received, when can then figure out just how large the download
is going to be. Then we can try to avoid showing the dialog if we think it is a
small download.

What is a small download? I arbitrarily said 8K (2 OnDataAvailable calls)

This small change made the usability of this feature much better IMHO. I think
it is ready to get checked in.

Comment 4

[David :Bienvenu]

Comment on attachment 139946 [details] [diff] [review]
updated patch 

looks good - two nits:

+    if (NS_SUCCEEDED(rv))
+    {	   
+      // Send progress notification.
+      if (mWebProgressListener)
+	 mWebProgressListener->OnProgressChange(nsnull, request, mProgress,
mContentLength, mProgress, mContentLength);

this can just be 
if (NS_SUCCEEDED(rv) && mWebProgressListener)
  mWebProgressListener->...


and this code, which I know you just moved, doesn't need the braces...

+    if (NS_FAILED(rv) && m_messenger)
+    {
+	 m_messenger->Alert("saveAttachmentFailed");
     }
+    else if (!m_dataBuffer)
+    {
+	 m_dataBuffer = (char*) PR_CALLOC(FOUR_K+1);
   }

Comment 5

[Scott MacGregor]

Attachment: updated patch with review comments

updating the diff with david's comments

Comment 6

[Scott MacGregor]

Comment on attachment 139947 [details] [diff] [review]
updated patch with review comments

carrying forward the sr

Comment 7

[Scott MacGregor]

fixed

Comment 8

[Scott MacGregor]

fixed on the m4 branch now too.