Closed
Bug 230649
Opened 21 years ago
Closed 21 years ago
nsIPref removal in Mail Window Front End
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: sspitzer)
References
Details
Attachments
(5 files)
|
5.10 KB,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
|
14.91 KB,
patch
|
Details | Diff | Splinter Review | |
|
13.89 KB,
patch
|
caillon
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
|
9.79 KB,
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
|
719 bytes,
patch
|
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
There appear to be just two JS users of nsIPref in mail window front end code.
|
Reporter | |
Comment 1•21 years ago
|
||
I've no idea why the commented out code was trying to use the default branch...
|
|
Reporter | |
Updated•21 years ago
|
Attachment #138823 -
Flags: review?(caillon)
|
||
Updated•21 years ago
|
Summary: nsIPref removal → nsIPref removal in Mail Window Front End
|
|
||
Comment 2•21 years ago
|
||
Comment on attachment 138823 [details] [diff] [review]
Proposed patch
The only thing I don't like is the fact that you are placing a singular item in
a variable name which is plural. I'd rather you use |gPrefBranch| than
|gPrefs|. r=caillon if you make that change (yes I realize that more lines
will need to change, but I think it will make the code make more sense).
|
|
Reporter | |
Updated•21 years ago
|
Attachment #138823 -
Flags: superreview?(bienvenu)
|
|
||
Updated•21 years ago
|
Attachment #138823 -
Flags: superreview?(bienvenu) → superreview+
|
|
Reporter | |
Comment 3•21 years ago
|
||
|
|
Reporter | |
Comment 4•21 years ago
|
||
Comment on attachment 139144 [details] [diff] [review]
Remove gPrefs and use existing pref variable
OK, so this version removes gPrefs because we already have the prefs in the
pref variable.
Attachment #139144 -
Flags: superreview?(bienvenu)
Attachment #139144 -
Flags: review?(caillon)
|
|
Reporter | |
Comment 5•21 years ago
|
||
|
|
Reporter | |
Comment 6•21 years ago
|
||
Comment on attachment 139156 [details] [diff] [review]
Rename to gPrefBranch
OK, this version should make everyone happy :-)
Attachment #139156 -
Flags: superreview?(bienvenu)
Attachment #139156 -
Flags: review?(caillon)
|
|
||
Comment 7•21 years ago
|
||
Comment on attachment 139156 [details] [diff] [review]
Rename to gPrefBranch
Better. thanks.
Attachment #139156 -
Flags: review?(caillon) → review+
|
|
||
Updated•21 years ago
|
Attachment #138823 -
Flags: review?(caillon)
|
|
||
Updated•21 years ago
|
Attachment #139144 -
Flags: superreview?(bienvenu)
Attachment #139144 -
Flags: review?(caillon)
|
|
||
Comment 8•21 years ago
|
||
Comment on attachment 139156 [details] [diff] [review]
Rename to gPrefBranch
sr=bienvenu, but I suspect we need to make the matching changes in thunderbird.
Attachment #139156 -
Flags: superreview?(bienvenu) → superreview+
|
|
Reporter | |
Comment 9•21 years ago
|
||
Fix checked in to SeaMonkey.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 10•21 years ago
|
||
|
|
Reporter | |
Updated•21 years ago
|
Attachment #139196 -
Flags: review?(bienvenu)
|
|
||
Updated•21 years ago
|
Attachment #139196 -
Flags: review?(bienvenu) → review+
|
|
||
Comment 11•21 years ago
|
||
tbird patch checked in as well.
|
|
Reporter | |
Comment 12•21 years ago
|
||
I missed this out last time because it caused a conflict with another patch :-[
|
|
||
Updated•21 years ago
|
Attachment #139731 -
Flags: superreview+
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•