230660 - [FIX] XML prettyprint does not work on UTF16-LE encoded page

Status: RESOLVED FIXED

(Core :: XML, defect, P2)

Description

[Sekundes]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7a) Gecko/20040108
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; rv:1.7a) Gecko/20040108

Summary says it all

Reproducible: Always

Steps to Reproduce:

Comment 1

[Alex Hirzel]

Tried to create a testcase, but every single editor on my system choked on the
file.  Even Vim.  Maybe for some odd-ball reason Mozilla has a problem with the
raw length of the line -- 154,000+ characters.

Maybe someone with the horsepower on their system to do it could break the file
up  over multiple lines and see how it works.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031208

Comment 2

[Boris Zbarsky [:bzbarsky]]

To sicking.   The problem is that the page is UTF-16 (not ascii-compatible,
therefore) and his prettyprinter CSS doesn't have @charset rules.  So we try to
decode it as UTF-16 and that fails badly.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fixes the problem

The CSSLoader stuff is a minor improvement to how we do charsets a tad, plus
converting logging to use PR_LOG instead of printf.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138852 [details] [diff] [review]
Fixes the problem

I call upon thee, CSSLoader not-fearers!  Review!  ;)

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 138852 [details] [diff] [review]
Fixes the problem

* sicking fights off CSSLoader deamons with a keyboard

Comment 6

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 7

[Peter Van der Beken [:peterv]]

Would it make sense to use "UTF-8" instead of "utf-8" in the @charset rule?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Doesn't matter, really.  I could change that, sure.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

*** Bug 230811 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

Checked in.