230677 - Pressing Enter in autocomplete goes to selected URL instead of URL in address bar

Status: RESOLVED DUPLICATE of bug 255116

(Firefox :: Address Bar, defect, P3)

Description

[Jesse Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040108
Firebird/0.8.0+ (MozJF)

Steps to reproduce:
1. Start typing a URL into the address bar.
2. Down-arrow into address bar autocomplete.
3. Press Home.
4. Add something to the beginning of the URL.

Result: Autocomplete doesn't go away or update.
Expected: Autocomplete should go away (since I'm making changes not at the end
of the URL).

5. Press enter.

Result: Firebird goes to the URL I selected in autocomplete.
Expected: Firebird goes to the URL in the address bar.

Comment 1

[Jesse Ruderman]

The same bug exists in form autocomplete.  It has recently been made more
annoying by the fix for bug 20022.  If my cursor happens to be just below the
textbox, pressing Enter selects the item under the cursor instead of submitting
the form.  (Before the fix for bug 20022, I had to move the cursor at least a
pixel to make the bug show up.)

Comment 2

[Jesse Ruderman]

See also bug 233327, same bug for using the up/down arrow keys (instead of
pressing enter).

Comment 3

[Sekundes]

I can reproduce this in Mozilla 1.6.
Mozilla bug?

Comment 4

[Jesse Ruderman]

I think Firefox has forked autocomplete code.

Comment 5

[Jesse Ruderman]

One reason this bug is annoying: it happens whenever I right-click the address
bar, select "Paste", and hit the enter key on the numpad with my right hand
while it's still on the mouse.

Comment 6

[Nian Liu(n/a in a long time)]

seems related to 255461 and 255324, especially 255461. after patch them, i can't
reproduce the bug.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040812

Comment 7

[Blake Ross]

If we're going to fix this for 1.0, I think it should work like this:

If the last thing you did was hit up or down arrow, you're clearly choosing
something from the autocomplete dropdown, so enter should take you to that url.
Otherwise, if you did pretty much anything else that would move the cursor in
the urlbar, such as left/right arrow, home, end, or pressing a key, you're back
into edit-the-url mode and pressing enter should take you to the url.

It's important that we get this behavior correct and that this be implemented
properly. If it's too hard to get this just right, we should minus it for 1.0.

Comment 8

[Nian Liu(n/a in a long time)]

blake, could you pls. review 255461?

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

annoying but Not a "blocker"

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Pressing Home now closes the autocomplete popup (bug 255116), so it seems to me
as the behavior described in Blake's comment 7 is now the current behavior.

Jesse, Fixed?

Comment 11

[Jesse Ruderman]

*** This bug has been marked as a duplicate of 255116 ***