230687 - Build failure in mozilla code while building libgkgfx.so.

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Shanmu]

User-Agent:       Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.6b) Gecko/20031211
Build Identifier: Mozilla/5.0 (X11; U; OSF1 alpha; en-US; rv:1.6b) Gecko/20031211

Starting Jan.10th the mozilla code fails to build
with the following errors while building nsRegion.cpp.

cxx: Error: ../../dist/include/gfx/nsRegion.h, line 73: class
          "nsRegion::nsRectFast" has no member "operator="
      nsRectFast::operator = (aRect);               // Copy only the nsRectFast part
------------------^
cxx: Info: 1 error detected in the compilation of "nsRegion.cpp".


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Actual Results:  
Build failed

Expected Results:  
Should have built successfully.

Comment 1

[Olivier Cahagne]

regression from bug 228378. Did you later test compiling as it seems bug 228378
comment 16 seems to mention a fix for IRIX, AIX, HP-UX, which may have also
fixed OSF/1. There's also patch for bug 230118 that was later backed out.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Shanmugavelu, can you try changing "nsRectFast::operator = (aRect);" to
"nsRect::operator = (aRect);" and see if that compiles?

Comment 3

[Shanmu]

I tried to compile with the change

nsRect::operator = (aRect);

But still it fails to compile with the same errors.
cxx: Error: ../../dist/include/gfx/nsRegion.h, line 73: class "nsRect" has no
          member "operator="
      nsRect::operator = (aRect);               // Copy only the nsRectFast part
--------------^
cxx: Info: 1 error detected in the compilation of "nsRegion.cpp".

This happens with the latest code.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This must be a compiler bug. nsRect and nsRectFast should have an implicit
operator=. You could try defining the obvious operator= in nsRect.h

Comment 5

[Matthias Versen [:Matti]]

*** Bug 231041 has been marked as a duplicate of this bug. ***

Comment 6

[g. fischer]

"You could try defining the obvious operator= in nsRect."

nice. did somebody do try this?
success? patch??

thanks

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Try this

Comment 8

[g. fischer]

hello,

patch works!

THANKS!!!

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fix checked in.