230807 - Calendar uses xmlterm's "program launch"-accelerator key (commandkey "7")

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Mikko Virkkilä]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030821
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030821

Both calendar and xmlterm use 7 as their commandkey. This means that ctrl+7 is
used for launching either app. This is of course not desired.

The offending files can be seen using this search in lxr:
http://lxr.mozilla.org/seamonkey/search?string=commandkey%23%227%22

Calendar should change its commandkey to a vacant, unused value.
Out of numbers 0-9 currently 3, 8 and 9 are available.




Reproducible: Always

Steps to Reproduce:
1. Go to
http://lxr.mozilla.org/seamonkey/source/extensions/tasks/resources/locale/en-US/tasksOverlay.dtd#5
2. Go to
http://lxr.mozilla.org/seamonkey/source/extensions/xmlterm/ui/locale/en-US/xmltermOverlay.dtd#3
3. Notice how both specify .commandkey "7"

Actual Results:  
The calendar file
http://lxr.mozilla.org/seamonkey/source/extensions/tasks/resources/locale/en-US/tasksOverlay.dtd
 specifies <!ENTITY other-cal-cmd.commandkey "7">

Expected Results:  
The calendar file should specify 3,8 or 9, or some other vacant commandkey

Comment 1

[Mikko Virkkilä]

Attachment: patch using commandkey "3"

Proposed patch for those two files using commandkey "3". 

Should I also make a patch for the file
mozilla/calendar/resources/locale/en-US/overlay.dtd and perhaps for the other
locales as well?

Comment 2

[Mikko Virkkilä]

Should have a preview button. That should of course say "Proposed patch for the
calendar file using commandkey "3".

Comment 3

[Mostafa Hosseini]

Reassiging to [e-mail] since he originally created that file and I
don't have cvs access to that location anyway.

http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/extensions/tasks/resources/locale/en-US/tasksOverlay.dtd

Comment 4

[Mikko Virkkilä]

Attachment: Patch for both en-US files

As per timeless suggestion (irc) I have modified the patch to use the number 8
since aim on netscape uses 3. I have also modified the patch so that it now
patches mozilla/calendar/resources/locale/en-US/overlay.dtd as well.

Comment 5

[Mikko Virkkilä]

Attachment: changes the commandkey for all locales

This patch will patch all locales including the two en-US ones to use 8 as the
commandkey

Comment 6

[[e-mail]]

Side note: View/Zoom/Original Size is Ctrl+0

Comment 7

[[e-mail]]

Comment on attachment 138973 [details] [diff] [review]
Patch for both en-US files

Cancelling review on obsolete patch.

Comment 8

[[e-mail]]

This is fixed now, right?