Closed
Bug 230931
Opened 21 years ago
Closed 21 years ago
nsFileStreams.h should not #include nsReadLine.h
Categories
(Core :: Networking, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
Attachments
(1 file)
|
1.82 KB,
patch
|
bzbarsky
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
nsReadLine.h contains some static functions; when nsFileStreams includes that it
causes a build warning when nsFileStreams.h is included by nsNetModule.cpp
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #139058 -
Flags: superreview?(darin)
Attachment #139058 -
Flags: review?(bz-vacation)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•21 years ago
|
||
Comment on attachment 139058 [details] [diff] [review]
patch
r=bzbarsky, though this static function really needs to go away...
Attachment #139058 -
Flags: review?(bz-vacation) → review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
NS_InitLineBuffer can't easily be moved into a .cpp file, because spellchecker
uses it.
of course spellchecker reimplements NS_ReadLine, as an nsACString& version...
|
|
||
Comment 4•21 years ago
|
||
Oy. a "line" makes no sense for an nsACString&, but whatever.
|
||
Updated•21 years ago
|
Attachment #139058 -
Flags: superreview?(darin) → superreview+
|
|
Assignee | |
Comment 5•21 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
V
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsReadLine.h&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/public&command=DIFF_FRAMESET&rev1=1.3&rev2=1.4
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsFileStreams.h&branch=&root=/cvsroot&subdir=mozilla/netwerk/base/src&command=DIFF_FRAMESET&rev1=1.29&rev2=1.30
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•