230934 - The second sed script for extracting MSVC version is incorrect.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Wan-Teh Chang]

In mozilla/configure.in, we have:

        # Determine compiler version
        CC_VERSION=`"${CC}" -v 2>&1 | grep Version | sed -e 's|.* Version ||' |
sed -e 's|[ ]*$||'`

The second sed script, s|[ ]*$||', is incorrect.
I will attach a shell script that demonstrates the
bug.

Comment 1

[Wan-Teh Chang]

Attachment: A shell script that demonstrates the bug

Save this script as "foo.sh".

If you run it, you get the wrong result:

12.00.8804 for 80x86

The expected result is:

12.00.8804

This shows that the second sed script fails to
chop off the text ("for 80x86") after the
version number.

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch

1. A performance optimization: pass both -e <script>
options to the same invocation of sed.

2. The real bug fix: changed the second sed script to
's| .*||', which deletes everything from the first
space character to the end of the line.

Comment 3

[Wan-Teh Chang]

Attachment: Proposed patch v1.1

Added a cosmetic change that's unrelated to this bug:
remove the unnecessary space in awk's variable names
"$ 1", "$ 2", and "$ 3".

Comment 4

[Wan-Teh Chang]

Patch checked in.

Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1293; previous revision: 1.1292
done