Closed
Bug 230947
Opened 21 years ago
Closed 21 years ago
[FIX]Make attr and inline stylesheet handling more unified
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(2 obsolete files)
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 139576 [details] [diff] [review] (Av1) Like so [Checked in: Comment 4] jst, what do you think?
Attachment #139576 -
Flags: superreview?(jst)
Attachment #139576 -
Flags: review?(jst)
|
|
Assignee | |
Updated•21 years ago
|
Priority: -- → P1
Summary: Make attr and inline stylesheet handling more unified → [FIX]Make attr and inline stylesheet handling more unified
Target Milestone: --- → mozilla1.7alpha
|
||
Comment 3•21 years ago
|
||
Comment on attachment 139576 [details] [diff] [review] (Av1) Like so [Checked in: Comment 4] r+sr=jst
Attachment #139576 -
Flags: superreview?(jst)
Attachment #139576 -
Flags: superreview+
Attachment #139576 -
Flags: review?(jst)
Attachment #139576 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Fix checked in. Saved about 800 bytes in mZ. ;)
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•21 years ago
|
Attachment #139576 -
Attachment description: Like so → Like so
[Checked in: Comment 4]
Attachment #139576 -
Attachment is obsolete: true
|
|
||
Updated•21 years ago
|
Attachment #139576 -
Attachment description: Like so
[Checked in: Comment 4] → (Av1) Like so
[Checked in: Comment 4]
|
|
||
Comment 5•21 years ago
|
||
Fix for
{ <http://tinderbox.mozilla.org/SeaMonkey/warn1074744420.4383.html#jst>
6. content/html/document/src/nsHTMLDocument.cpp:384 (See build log
excerpt)
Unused variable `nsresult rv'
382 nsDocument::ResetToURI(aURI, aLoadGroup);
383
384 nsresult rv = NS_OK;
385
386 InvalidateHashTables();
}|
|
||
Comment 6•21 years ago
|
||
Comment on attachment 139682 [details] [diff] [review] (Bv1) <nsHTMLDocument.cpp> [Checked in: Comment 7] 'r=?': (see comment 5) I have no compiler: Could you compile/test/(super-)review/check-in it ? Thanks.
Attachment #139682 -
Flags: superreview?(jst)
Attachment #139682 -
Flags: review?(jst)
|
|
||
Comment 7•21 years ago
|
||
Thanks! Fix checked in.
|
|
||
Comment 8•21 years ago
|
||
Comment on attachment 139682 [details] [diff] [review] (Bv1) <nsHTMLDocument.cpp> [Checked in: Comment 7] s+ & sr+, per comment 7 ;->
Attachment #139682 -
Attachment description: (Bv1) <nsHTMLDocument.cpp> → (Bv1) <nsHTMLDocument.cpp>
[Checked in: Comment 7]
Attachment #139682 -
Attachment is obsolete: true
Attachment #139682 -
Flags: superreview?(jst)
Attachment #139682 -
Flags: superreview+
Attachment #139682 -
Flags: review?(jst)
Attachment #139682 -
Flags: review+
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•