230947 - [FIX]Make attr and inline stylesheet handling more unified

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 211376 comment 8

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: (Av1) Like so [Checked in: Comment 4]

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139576 [details] [diff] [review]
(Av1) Like so
[Checked in: Comment 4]

jst, what do you think?

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 139576 [details] [diff] [review]
(Av1) Like so
[Checked in: Comment 4]

r+sr=jst

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fix checked in.  Saved about 800 bytes in mZ.  ;)

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <nsHTMLDocument.cpp> [Checked in: Comment 7]

Fix for
{ <http://tinderbox.mozilla.org/SeaMonkey/warn1074744420.4383.html#jst>

6.	content/html/document/src/nsHTMLDocument.cpp:384 (See build log
excerpt)
	Unused variable `nsresult rv'

382 nsDocument::ResetToURI(aURI, aLoadGroup);
383 
384 nsresult rv = NS_OK;
385 
386 InvalidateHashTables();
}

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 139682 [details] [diff] [review]
(Bv1) <nsHTMLDocument.cpp>
[Checked in: Comment 7]

'r=?': (see comment 5)
I have no compiler: Could you compile/test/(super-)review/check-in it ? Thanks.

Comment 7

[Johnny Stenback (:jst)]

Thanks! Fix checked in.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 139682 [details] [diff] [review]
(Bv1) <nsHTMLDocument.cpp>
[Checked in: Comment 7]


s+ & sr+, per comment 7 ;->