230970 - nsExternalAppHandler needs no virtual functions

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

This class does not have any subclasses. The functions need not be virtual.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

nsExternalProtocolHandler also does not need its virtual dtor

nsExternalHelperAppService does need it, because it implements ::Release and
does have nsOSHelperAppService as subclass, whose destructor should be called.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139108 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 139108 [details] [diff] [review]
patch

I just realized...
nsExternalProtocolHandler is a subclass of nsSupportsWeakReference, so it needs
a virtual dtor (and probably gets one anyway); so I won't check the change to
nsExternalProtocolHandler in

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

err, nevermind comment 3. it doesn't need a virtual destructor anyway. it will
only get deleted through its own Release impl.

Comment 5

[Darin Fisher]

Comment on attachment 139108 [details] [diff] [review]
patch

sr=darin

this non-virtual dtor thing should be used in more places.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in