Closed
Bug 231027
Opened 21 years ago
Closed 21 years ago
refactor code that calls ComputeStyleChangeFor
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.7alpha
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch])
Attachments
(1 file)
|
8.88 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
After bug 15608, we have the same pattern in two places, and bug 214013 will add
a third. It should be its own function.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #139148 -
Flags: superreview?(bz-vacation)
Attachment #139148 -
Flags: review?(bz-vacation)
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [patch]
Target Milestone: --- → mozilla1.7alpha
|
|
Assignee | |
Comment 2•21 years ago
|
||
Actually, bug 214013 won't add a third -- there are two differences (the hint
from nsIStyledContent::GetAttributeChangeHint and the need to call
nsIFrame::AttributeChanged).
|
||
Comment 3•21 years ago
|
||
Comment on attachment 139148 [details] [diff] [review]
patch
Ah, good catch on the AttributeChanged() thing.... r+sr=bzbarsky.
Attachment #139148 -
Flags: superreview?(bz-vacation)
Attachment #139148 -
Flags: superreview+
Attachment #139148 -
Flags: review?(bz-vacation)
Attachment #139148 -
Flags: review+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Fix checked in to trunk, 2004-01-17 14:43 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•