231135 - NS_NewLocalFile rv isn't checked in nsProfile::CreateNewProfileWithLocales

Status: RESOLVED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[timeless]

1622         rv = NS_NewLocalFile(nsDependentString(nativeProfileDir), PR_TRUE,
(nsILocalFile **)((nsIFile **)getter_AddRefs(profileDir)));
1623 
1624         // this prevents people from choosing there profile directory
1625         // or another directory, and remove it when they delete the profile.
1626         // append profile name
1627         profileDir->Append(nsDependentString(profileName));

NS_NewLocalFile can fail (hence rv), when it fails then profileDir will be null,
and 1627 will crash.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Check rv for failure

per timeless' request

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 139205 [details] [diff] [review]
Check rv  for failure

sr=dbaron, but please find an owner/peer to review

Comment 3

[benc]

        // this prevents people from choosing there profile directory
 
"their"?

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 139205 [details] [diff] [review]
Check rv  for failure

r=dveditz (and fix s/there/their/ in the following comment as ben mentioned)

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: Same as above, with spelling fix

Fixed spelling error

Comment 6

[timeless]

mozilla/profile/src/nsProfile.cpp 	1.305