Closed
Bug 231157
Opened 21 years ago
Closed 21 years ago
deCOMtaminate nsCSSFrameConstructor
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
(Keywords: perf)
Attachments
(1 file)
|
54.93 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
nsCSSFrameConstructor doesn't really need to have an XPCOM interface. There's
exactly 1 place where it's currently used from outside layout, and that's easily
solved by making an existing PresShell method public.
|
Assignee | |
Comment 1•21 years ago
|
||
- Remove nsIStyleFrameConstruction and nsICSSFrameConstructor, changed
nsCSSFrameConstructor methods to non-virtual. Made some of the methods
protected that didn't need to be public.
- Put ReconstructFrames onto nsIPresShell.
- Move StyleSet destruction to PresShell dtor, in an attempt to not regress bug
100270 (I don't believe any layout objects are held onto by the
FrameConstructor, so it shouldn't matter when it's destroyed)
- Cleaned up the xbl form prefs so that we only check once, not every time a
frame constructer is created.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #139211 -
Flags: superreview?(dbaron)
Attachment #139211 -
Flags: review?(dbaron)
Comment on attachment 139211 [details] [diff] [review]
patch
You'll have a little merging to do (|RestyleElement| was added, and it should
be listed in the header near RestyleLaterSiblings (so it's protected)).
Attachment #139211 -
Flags: superreview?(dbaron)
Attachment #139211 -
Flags: superreview+
Attachment #139211 -
Flags: review?(dbaron)
Attachment #139211 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
||
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•