231166 - [FIXr]Can't click on a element with an :after content, but with a child with dispay none

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Xanthor Sccas]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031008
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031008

Suppose we write a "a" element, with another inline element in it (like "span").
If we create with CSS a text after this a element (with a:after {content :
'...'}), the text is part of the a element, so we can click on it to access to
the link.
If we put, by CSS, the display to the subelement of "a" (in our exemple : the
span element), we'll see only the text added with :after. It still appears we
can click on it (for example, the URL is shown in the status bar), and we can
open it with right click and "open in a new tab" for example.
but if we directly click on it, (or ctrl+click), nothing occures.


Well, maybe it isn't very clear, but look at the demo URL...

Reproducible: Always

Steps to Reproduce:
1. Create a a element with a sub element
2. Set the dispay to this sub element to none
3. Add text (or whatever) after the a element with :after
4. Try to click to access to the link
Actual Results:  
Nothing occures if we click directly

Expected Results:  
Mozilla should have open the link

It was verified in differents build of Mozilla or Firebird, on linux and windows...

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** This bug has been marked as a duplicate of 46891 ***

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually...

Comment 3

[Xanthor Sccas]

Well yes, this bug is linked with
http://bugzilla.mozilla.org/show_bug.cgi?id=46891 but the testcase of that bug
(http://bugzilla.mozilla.org/attachment.cgi?id=12097&action=view) and the other
URL work for me. (And I've already test it before submiting)
Maybe it is not exaclty the same bug ?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I know.  That's why I reopened it.

Comment 5

[Jesiah S]

I see this also on LInux 2004012608

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

If there's still a problem, could you attach the testcase to the bug, and if
not, mark as worksforme?

Comment 7

[Xanthor Sccas]

Attachment: Testcase

This bug is still a problème :¬/

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Minimal testcase, HTML

Note that this is a problem with :before too.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145899 [details] [diff] [review]
Fix

David, would you review?  The issue is that the code later on looks at
pseudotag to avoid looking for before/after content on the before/after
pseudoelements.  But this code clobbered the pseudo (with the one for the
undisplayed map entry), so we ended up reframing (because we thought we didn't
already have a before/after and needed one), at which point the event system
got all confused (because the new frames were size 0x0, so GetFrameForPoint
failed to deal).

This fixes the unnecessary reframing, but the event issue really needs
addressing...

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 145899 [details] [diff] [review]
Fix

r+sr=dbaron, but maybe you want to declare all three pseudo-tag variables as
|nsIAtom *const|?

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Make those const

Good idea.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145947 [details] [diff] [review]
Make those const

Could this please be approved for 1.7?	This is a very safe fix; just renaming
variables so a value we need later on doesn't get clobbered.

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 145947 [details] [diff] [review]
Make those const

a=asa (on behalf of drivers) for checkin to 1.7

Comment 15

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.8a.

Comment 16

[Boris Zbarsky [:bzbarsky]]

Actually, reopening pending 1.7 checkin.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Checked in to 1.7 branch.