231231 - next item should be get before the callback is called in moz_container_forall

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Robin Lu]

in moz_container_forall,
    while (tmp_list) {
        MozContainerChild *child;
        child = tmp_list->data;
        (* callback) (child->widget, callback_data);
        tmp_list = tmp_list->next;
    }
the next item is get after the callback is called. This will cause problems when
the callback is gtk_widget_destroy, the current list item is freed in
moz_container_remove and the tmp_list->next will be a random pointer.

Comment 1

[Robin Lu]

Attachment: patch

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 139262 [details] [diff] [review]
patch

Good catch.

Comment 3

[Robin Lu]

checked in.
Thank you all!