231343 - Fold AutoCopy service into nsSelection.cpp

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Brian Ryner (not reading)]

The AutoCopy service (layout/base/src/nsAutoCopy.cpp) is fairly trivial - a good
half of the file is comments and XPCOM goop.  I'd say it should just be folded
into nsSelection.cpp, and don't bother with using the service manager or an
XPCOM interface.  There are no other consumers of the service.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

While writing this patch, I noticed that many implementors of
nsISelectionListener::NotifySelectionChanged() were using the |short| type in
C++ to correspond to a |short| in IDL, whereas the correct type to use is
|PRInt16|.  I fixed that as well.

Comment 2

[Brian Ryner (not reading)]

checked in