231447 - space after charset name produce wrong charset detection

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Adam Hauner]

Space after charset name in example will lead Mozilla to detect wrong charset -
Windows-1252 instead Windows-1250"

<meta http-equiv="Content-Type" content="text/html ; charset=windows-1250 ">
                                                                         ^
If space is missing, everything is correct. Maybe we should trip charset name.

Reproduced with 1.4.1/1.5/1.6 on Win2K

Comment 1

[Adam Hauner]

Attachment: testcase

Comment 2

[Jungshik Shin]

Attachment: patch

patch.
I removed tabs and made the parser skip the leading white spaces as well.

Comment 3

[Jungshik Shin]

Comment on attachment 139411 [details] [diff] [review]
patch

asking for r/sr

Comment 4

[Boris Zbarsky [:bzbarsky]]

It'll likely take me a bit (up to 2 weeks, maybe) to get to this.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

couldn't this use NS_ParseContentType?
http://lxr.mozilla.org/seamonkey/source/netwerk/base/public/nsNetUtil.h#669

Comment 6

[Simon Montagu :smontagu]

*** Bug 200134 has been marked as a duplicate of this bug. ***

Comment 7

[Jungshik Shin]

re: comment #5
I took a look at it, but it's not generic enough for our purpose here. I may
modify it to be more generic, but that would increase the size of the inline
function. So, I'd rather go with the patch. Simon and Boris, can you review? 

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 139411 [details] [diff] [review]
patch

Does CharAt() handle indices past end-of-string reasonably?

Comment 9

[Jungshik Shin]

Attachment: updated patch

CharAt() doesn't do a 'sensisble' thing for an out-of-bound index. I added a
guard against it.

Comment 10

[Jungshik Shin]

Comment on attachment 140648 [details] [diff] [review]
updated patch

asking for r/sr

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 140648 [details] [diff] [review]
updated patch

sr=bzbarsky, but you may want to ask darin about pushing this quotes stuff down
into the necko function....

Comment 12

[Simon Montagu :smontagu]

Comment on attachment 140648 [details] [diff] [review]
updated patch

r=smontagu

Comment 13

[Jungshik Shin]

thanks for r/sr. fix landed. 
bz, I'm gonna write to darin about that.