231504 - Build strips symbols despite configure-option --disable-strip

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Christian Biere]

User-Agent:       Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.5) Gecko/20031209 Firebird/0.7
Build Identifier: Mozilla 1.6

Although, I've configured Mozilla with --disable-strip, during the build strip
is invoked for several files.
Therefore, I can't provide backtrace with full symbol information.

Reproducible: Always

Steps to Reproduce:
1. configure --disable-strip
2. make > make.log 2>&1
3. grep strip make.log

Actual Results:  
[...[
strip libnspr4.so
strip libplds4.so
strip libplc4.so

Expected Results:  
It shouldn't have stripped the files.

Comment 1

[Boris Zbarsky [:bzbarsky]]

NSPR uses a separate build system from the rest of the app, afaik....

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch

NSPR's configure script also has a --enable-strip
option, but it is incorrectly implemented.  If
you specify either --enable-strip or --disable-strip,
it sets the make variable ENABLE_STRIP to 1!

After you apply this patch, remember to regenerate
NSPR's configure script:
    % cd mozilla/nsprpub
    % autoconf

I believe you can work around this bug by not
configuring Mozilla with --disable-strip because
I think stripping is disabled by default.

Comment 3

[Wan-Teh Chang]

Patch checked in on the NSPR trunk (NSPR 4.5.1) and
NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.7a).