231536 - enhance sdrtest to work with mozilla's ########.s files

Status: RESOLVED FIXED

(NSS :: Tools, enhancement, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

sdrtest should be able decrypt the entries from mozilla's ########.s files
(where ######## is a random decimal number).
It should be able to do the base 64 decoding of the data.
It should be able to take input from stdin.

It should be able to create entries for that file.
It should be able to do base 64 encoding of the output.

It should display usage when invoked with no arguments.
And, of course, it should continue to work in the sdr.sh QA script.

Patch that does all these things forthcoming.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This patch adds a new command line option, -a means ascii encoded 
(base 64 encoded) input and/or output.
With this patch, the -i and -o options may use the name "-" to mean
read from stdin, or write to stdout.  The use of "-" implies -a.
That is, the input to stdin, or output to stdout is always base 64 encoded.
When an error occurs, the program now displays an error message that tells
what error occurred as well as what operation failed.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 139463 [details] [diff] [review]
patch v1

Bob, please review this patch.	Please see the comments in this bug for
explanation of the changes.

Comment 3

[Robert Relyea]

So I have a app which does most of this which I had not gotten around to
checking in. The basic differences is from your requirements are:

1) it's a new app, so there is no backward compatibility with sdrtest.
2) it always decodes base64 data.
3) It takes a general ascii string and picks out the base 64 data from the
stream, tries to decode the result, and if successfull outputs the result.

Also errors are sent to an optional logfile. The app was based on SDR, and has a
number style things you cleaned up in your patch. I'll attach it to the bug and
we can deside which (or both) should be checked in.

bob

Comment 4

[Robert Relyea]

Attachment: pwdecrypt.c

pwdecrypt.c

Comment 5

[Robert Relyea]

Attachment: Make file for the pwdecrypt command

Comment 6

[Robert Relyea]

Attachment: manifest for pwdecrypt command

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Bob, because this patch also fixes some bugs, I'd like to check it in,
so please review it.  I see no reason sdrtest and pwdecrypt can't coexist.

Comment 8

[Robert Relyea]

Comment on attachment 139463 [details] [diff] [review]
patch v1

r=relyea

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

/cvsroot/mozilla/security/nss/cmd/sdrtest/sdrtest.c,v  <--  sdrtest.c
new revision: 1.12; previous revision: 1.11

Thanks for the review Bob.

Comment 10

[Wan-Teh Chang]

This fix is in the NSS_3_9_BRANCH, which I just created
this morning.  So I changed the target milestone to 3.9.1.
Please let me know if you think this fix should not be in
a 3.9.x patch release.