231737 - nsSingleThreadVerifier link errors with vs.net2003

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[tor]

Your checkin for 112547 broke the vs.net2003 build in xpcom/obsolete
with unresolved nsSingleThreadVerifier symbols.

Comment 1

[tor]

Attachment: link xpcom strings to xpcom/obsolete

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Shouldn't xpcom/obsolete just link against xpcom just like everything else does?
 What were the errors?

Comment 3

[tor]

Same unresolved symbol errors in js/src/xpconnect/src.

Comment 4

[tor]

   Creating library xpcom_compat.lib and object xpcom_compat.exp

nsSpecialSystemDirectory.obj : error LNK2001: unresolved external 
symbol "public: void __thiscall nsSingleThreadVerifier::verifyThread(void)
const " (?verifyThread@nsSingleThreadVerifier@@QBEXXZ)

dlldeps.obj : error LNK2001: unresolved external symbol "public: void 
__thiscall nsSingleThreadVerifier::verifyThread(void)const " (?
verifyThread@nsSingleThreadVerifier@@QBEXXZ)

nsFileSpec.obj : error LNK2019: unresolved external symbol "public: void 
__thiscall nsSingleThreadVerifier::verifyThread(void)const " (?
verifyThread@nsSingleThreadVerifier@@QBEXXZ) referenced in function "protected: 
unsigned int __thiscall nsSharedBufferHandle<unsigned short>::get_refcount(void)
const " (?get_refcount@?$nsSharedBufferHandle@G@@IBEIXZ)

nsFileStream.obj : error LNK2001: unresolved external symbol "public: void 
__thiscall nsSingleThreadVerifier::verifyThread(void)const " (?
verifyThread@nsSingleThreadVerifier@@QBEXXZ)

nsIFileStream.obj : error LNK2001: unresolved external symbol "public: void 
__thiscall nsSingleThreadVerifier::verifyThread(void)const " (?
verifyThread@nsSingleThreadVerifier@@QBEXXZ)

nsFileSpecImpl.obj : error LNK2001: unresolved external symbol "public: void 
__thiscall nsSingleThreadVerifier::verifyThread(void)const " (?
verifyThread@nsSingleThreadVerifier@@QBEXXZ)

xpcom_compat.dll : fatal error LNK1120: 1 unresolved externals

make[1]: *** [xpcom_compat.dll] Error 96
make[1]: Leaving directory `/cygdrive/c/home/build/xpcom/obsolete'
make: *** [all] Error 2

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does your build have broken dependencies?  Maybe the new .cpp file added somehow
didn't get added for you.

Comment 6

[tor]

I'm doing a clobber build, so dependencies shouldn't really enter the picture.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

fixed

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Although maybe I need to add something to dlldeps.cpp -- but I don't think so,
since the string stuff is in XPCOM.