Closed Bug 231769 Opened 21 years ago Closed 21 years ago

Cannot change themes

Categories

(Core Graveyard :: Skinability, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: robertlaferla, Assigned: neil)

References

Details

(Keywords: regression)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040121
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7a) Gecko/20040121

Cannot change theme to anything but the Classic theme.


Reproducible: Always

Steps to Reproduce:
1.  Select Mozilla->Preferences
2.  Select Appearance->Themes
3.  Pick "Modern"
4.  Click Apply.
5.  Quit and restart app.
Actual Results:  
Still in Classic theme.


Expected Results:  
Should have switched to Modern theme.
Same problem in build 2004012408 / Windows2000
Reporter: Have you any idea when this did regress (you're testing nightly builds
right)?
Same problem with 2004011905 on mac os 10.2.8. Works fine with build 2004010905.
As a workaround you can change theme with "View" --> "Apply Theme".
Assignee: general → skinability
Status: UNCONFIRMED → NEW
Component: Browser-General → Skinability
Ever confirmed: true
Blocks: 232117
No longer blocks: 232117
*** Bug 232117 has been marked as a duplicate of this bug. ***
OK, so this is my fault, but I promise that this will be fixed by the time I
finish bug 230778.
Assignee: skinability → neil.parkwaycc.co.uk
Keywords: regression
*** Bug 232301 has been marked as a duplicate of this bug. ***
*** Bug 231866 has been marked as a duplicate of this bug. ***
*** Bug 232609 has been marked as a duplicate of this bug. ***
Flags: blocking1.7a?
*** Bug 233055 has been marked as a duplicate of this bug. ***
OS: MacOS X → All
Hardware: Macintosh → All
Bug 233055 is marked as a duplicate but contains in my opinion more helpful
informations about the problem as this one. We should dupe this bug instead.
Except this one is assigned to someone who knows what the problem is and how to
fix it....
*** Bug 233491 has been marked as a duplicate of this bug. ***
Boris you are right. But so it's depend on bug 230778. Or do i missread comment 5?
Depends on: 230778
neil,  does 

> but I promise that this will be fixed by the time I
finish bug 230778.

mean that we need that patch to fix this, or that the fix for this one is work
in parallel/yet to come?  

we need to figure out how to get theme switching working quickly so we can get
1.7a shipped
Flags: blocking1.7a? → blocking1.7a+
Bug 230778 doesn't have any visible benefit to users; it is a code level API
update.  If its breaking highly visible things a la theme switching, then I say
we should back the currently checked in patch out, and reland in beta when we
can get it fixed fully including the other attachment and any others which may
be looming.
I just tested to make sure that backing out 230778 did fix this bug, which it
did.  I subsequently backed out the patch which broke this after talking to
drivers.  Marking fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Not fixed.  1.8b2 2005030210   Mac OS X 10.3.8

Switching theme in view menu or in preferences has no effect. However, If I
change the theme and the profile, restart, change back to the first profile the
theme will change
284521 is probably a duplicate
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.